Bug 28672 - XF86CONFIGDIR is undefined when built with --disable-xorg
Summary: XF86CONFIGDIR is undefined when built with --disable-xorg
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-06-22 09:51 UTC by Dan Horák
Modified: 2010-11-24 15:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fix build with --disable-xorg (687 bytes, patch)
2010-06-22 09:51 UTC, Dan Horák
no flags Details | Splinter Review

Description Dan Horák 2010-06-22 09:51:09 UTC
Created attachment 36420 [details] [review]
fix build with --disable-xorg

The 10-evdev.conf file gets installed as /usr/share/X11/10-evdev.conf on platforms that built the server with --disable-xorg like s390/s390x. The definition/installation should be guarded with "if XORG" because it makes sense only when built with xorg.

The failed build can be seen at https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=166945 and successful one with this patch applied at https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=174826
Comment 1 Dan Horák 2010-06-22 09:52:09 UTC
Please use http instead of https if you would have problems accessing the URLs.
Comment 2 Julien Cristau 2010-06-22 10:02:01 UTC
Review of attachment 36420 [details] [review]:

Ack.  Can you send the patch to xorg-devel@lists.x.org?
Comment 3 Dan Horák 2010-06-22 11:08:01 UTC
Mail sent, but waits for a moderator.
Comment 4 Peter Hutterer 2010-11-24 15:30:12 UTC
commit ecdbe817fd7eb53fd1e7485c0492355f7f002d2a
Author: Dan Horák <dan@danny.cz>
Date:   Tue Jun 22 19:45:26 2010 +0200

    XF86CONFIGDIR is undefined when built with --disable-xorg (#28672)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.