Bug 28289 - McpAccountStorage::toggled is unimplemented
Summary: McpAccountStorage::toggled is unimplemented
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Danielle Madeley
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/da...
Whiteboard: review+ with minor changes
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-05-27 20:13 UTC by Danielle Madeley
Modified: 2010-05-28 19:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Danielle Madeley 2010-05-27 20:13:42 UTC
Emitting ::altered in an McpAccountStorage plugin does nothing.
Comment 1 Danielle Madeley 2010-05-27 20:14:46 UTC
This patch exposes an mcd_account_set_enabled that can be called by both the D-Bus property setter and by the McdAccountManager.
Comment 3 Danielle Madeley 2010-05-27 20:16:56 UTC
Err, poop. I posted this to the wrong bug report. Swapping the titles :-P
Comment 4 Simon McVittie 2010-05-28 03:03:58 UTC
> +gboolean
> +mcd_account_set_enabled (McdAccount *account,

This should be _mcd_account_set_enabled in mcd-account-priv.h (-priv is the MC equivalent of -internal in telepathy-glib). Adding more API to libmissioncontrol-server is deprecated, while we try to get rid of it.

> +  mcd_account_set_enabled (account, on, FALSE, &error);
> +  if (error != NULL)

Trivia: blank line before "if", please.
Comment 5 Danielle Madeley 2010-05-28 19:57:42 UTC
(In reply to comment #4)
> > +gboolean
> > +mcd_account_set_enabled (McdAccount *account,
> 
> This should be _mcd_account_set_enabled in mcd-account-priv.h (-priv is the MC
> equivalent of -internal in telepathy-glib). Adding more API to
> libmissioncontrol-server is deprecated, while we try to get rid of it.
> 
> > +  mcd_account_set_enabled (account, on, FALSE, &error);
> > +  if (error != NULL)
> 
> Trivia: blank line before "if", please.

Both of these are fixed and this is merged.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.