telepathy-sofiasip.c: In function ‘sofia_log_handler’:
telepathy-sofiasip.c:56: warning: implicit declaration of function ‘tpsip_log’
telepathy-sofiasip.c:56: error: ‘TPSIP_DEBUG_SOFIA’ undeclared (first use in this function)
Downstream bug (with possible patch):
I'm more favorable to the idea of removing --disable-debug because we now have the Debug interface, so it is useful to have it even on production systems.
(In reply to comment #0)
> Downstream bug (with possible patch):
You should tell them that their patch will hog memory with every debug statement.
Should come up with a proper fix.
I think --disable-debug is useful (for ultra-embedded performance freaks?) as long as the default is to enable debug logging.
You can just put the #ifdef right at the beginning of the function and it should be fine I think ?
A branch with a fix:
Why don't you just not all su_log_redirect when debug is disable, will it just print everything to stderr?
The rest look good to go.
The fix has been merged to branches master and telepathy-sofiasip-0.6; it will be available in the next respective releases.
(In reply to comment #4)
> Why don't you just not all su_log_redirect when debug is disable,
The code in the branch does the redirect in any case, but without ENABLE_DEBUG the log handler is a no-op. So no stderr printouts in this case. I think this is more logical than logging Sofia messages one way with --enable-debug, and another way with --disable-debug.
(In reply to comment #5)
> The fix has been merged to branches master and telepathy-sofiasip-0.6; it will
> be available in the next respective releases.
No longer needs fixing or review, then :-)