Bug 27255 - Port Salut to use the message mixin for text channels.
Summary: Port Salut to use the message mixin for text channels.
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Mike Ruprecht
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ma...
Keywords: patch
Depends on:
Reported: 2010-03-22 20:21 UTC by Mike Ruprecht
Modified: 2010-03-26 00:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Mike Ruprecht 2010-03-22 20:21:23 UTC
See summary.
Comment 1 Sjoerd Simons 2010-03-23 12:42:03 UTC
I discussed with smcv about the tp_mixin_message_sent, our general conclusion was that the function should be called as soon as the CM determines it's theoretically possible to send the message (So in salut call it basically right away, the only reason to call it with an error is when the contact is offline)..  Patches for the tp-glib doc and the spec to clarify this are appreciated :)

The text channel gets the id from the stanza's id, but afaik salut doesn't set the id on messages?

+  token = g_strdup_printf ("%d", g_random_int ());

That's not really random enough :) Although that really is a dummy value. Probably best to grab the id generation function for gabble (which uses libuuid optionally) and use that for the id/token generation in salut as well.
Comment 2 Mike Ruprecht 2010-03-23 19:36:05 UTC
Updated per your review comments.

Patch to clarify tp-glib documentation: http://bugs.freedesktop.org/show_bug.cgi?id=27281
Patch to clarify tp-spec specification: http://bugs.freedesktop.org/show_bug.cgi?id=27282
Comment 3 Mike Ruprecht 2010-03-24 23:19:06 UTC
Updated once again per your review comments in #telepathy.

Even with the updated delivery reports, it doesn't quite act the same as before porting. Before porting, if a user was offline and you'd send them a message, it wouldn't display the message normally, it would just say there was an error sending it (because they were offline). After porting, it shows the message normally, then says there was an error sending it (also because they were offline). This is due to tp_message_mixin_sent being sent earlier than its equivalent before, and because it would send sent or error, now it sends both.

Not that it's a big deal, just thought it would be good to mention.
Comment 4 Sjoerd Simons 2010-03-25 08:35:31 UTC
That's not unfixable, but i don't think it's worth the trouble atm. please merge :)
Comment 5 Mike Ruprecht 2010-03-26 00:14:42 UTC

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.