Bug 27193 - dbus-glib-0.84 fails testsuite
Summary: dbus-glib-0.84 fails testsuite
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: r+ from walters
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-03-19 04:40 UTC by Pacho Ramos
Modified: 2011-01-10 04:30 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
build.log (84.06 KB, text/plain)
2010-03-19 04:40 UTC, Pacho Ramos 		Details
Run run-with-tmp-session-bus.sh directly rather than via ${SHELL} (1.97 KB, patch)
2011-01-04 10:08 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Pacho Ramos 2010-03-19 04:40:24 UTC 
Created attachment 34235 [details]
build.log

Similar to https://bugs.freedesktop.org/show_bug.cgi?id=19647

From our downstream bug report:
http://bugs.gentoo.org/show_bug.cgi?id=254192#c4

and reproduced myself with 0.84

Thanks a lot
Comment 1 Simon McVittie 2011-01-04 10:07:15 UTC 
Patch in gitweb, I'll attach it in a moment.
Comment 2 Simon McVittie 2011-01-04 10:08:10 UTC 
Created attachment 41633 [details] [review]
Run run-with-tmp-session-bus.sh directly rather than via ${SHELL}

It has a correct #!/bin/sh line and is executable, so just running it is
fine. This avoids running it under a user's chosen interactive shell,
which might be non-POSIX (zsh, csh). Gentoo Portage apparently sets
SHELL to /bin/false, presumably to trap this sort of thing.
Comment 3 Colin Walters 2011-01-06 14:20:33 UTC 
Review of attachment 41633 [details] [review]:

Looks good, thanks!
Comment 4 Simon McVittie 2011-01-10 04:30:32 UTC 
Thanks, fixed in git for 0.94.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.