Bug 26860 - [945GM bisected] Glean/readpixPerf will make system hang
Summary: [945GM bisected] Glean/readpixPerf will make system hang
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other Linux (All)
: medium critical
Assignee: Li Peng
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO
Depends on:
Blocks:
 
Reported: 2010-03-03 05:50 UTC by zhao jian
Modified: 2017-10-06 14:54 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
xorg.0.log (21.44 KB, text/plain)
2010-03-03 05:50 UTC, zhao jian
no flags Details

Description zhao jian 2010-03-03 05:50:35 UTC
Created attachment 33722 [details]
xorg.0.log

System Environment:
--------------------------
Libdrm:         (master)766fa7909f3a1af27e60f3529a6a3318cc406f67
Mesa:           (master)20443f969d78efb8437083b39b9ddcf4c08aa6cf
Xserver:                (master)de86a3a3448f0a55c1cd99aee9ea80070a589877
Xf86_video_intel:       (master)a0ee9c3d9c72962c8d513ec8c43dd4a21e316947
Kernel: (drm-intel-next)72ddbd39f39b3cc5f1f661f97e67f2a497c4d57a

Bug detailed description:
-------------------------
Glean case readpixPerf will make the system hang, and sometimes it will auto reboot. I find it was caused by the kernel in drm-intel-next branch. Its good commit is 4a42de1a3c2fc04659611338da65e472d04c78b4(built on 2010-01-19), the bad commit is 72ddbd39f39b3cc5f1f661f97e67f2a497c4d57a(built on 2010-01-27). But this branch was rebased. These two commits can't be found now. I will try to find the commits later. 

Reproduce steps:
--------------------
1. xinit& 
2. ./glean -r readpixPerf -o --quick -v -v -v -t readpixPerf
Comment 1 zhao jian 2010-03-03 21:39:46 UTC
It only on 934GM do readpixPerf make system hang. And on G45 and GM965 are well. 
Comment 2 zhao jian 2010-03-04 00:09:47 UTC
(In reply to comment #1)
> It only on 934GM do readpixPerf make system hang. And on G45 and GM965 are
> well. 
> 
A typo. It should be 945GM. 
Comment 3 zhao jian 2010-03-07 22:26:58 UTC
This issuee only exits on our drm-intel-next branch, not exist on 2.6.33. So it not blocks our Q1 release. 
Comment 4 zhao jian 2010-03-09 00:24:06 UTC
It was caused by the commit 060e645ac0181f499478a7be0ccb8a5600edc71a. 
commit 060e645ac0181f499478a7be0ccb8a5600edc71a
Author: Li Peng <peng.li@linux.intel.com>
Date:   Wed Feb 10 01:54:24 2010 +0800

    drm/i915: Fix OGLC performance regression on 945

    He Shuang reported an OGLC performance regression introduced in the patch
    "enable memory self refresh on 9xx", In that patch, SR on 945 is disabled
    everytime when calling intel_mark_busy(), while too much of such operation
    will impact performance. Actually disable SR is necessary only when GPU and
    Crtc changing from idle to busy. This patch make such optimization.

    It fixes upstream bug
    http://bugs.freedesktop.org/show_bug.cgi?id=26422

    Signed-off-by: Li Peng <peng.li@intel.com>
    Signed-off-by: Eric Anholt <eric@anholt.net>
Comment 5 Gordon Jin 2010-03-09 01:03:33 UTC
Peng, can you take a look? This happens only on our 945GM notebook, and fine on our 945GME netbooks. You can remote access if you want.
Comment 6 Li Peng 2010-03-09 19:25:00 UTC
(In reply to comment #5)
> Peng, can you take a look? This happens only on our 945GM notebook, and fine on
> our 945GME netbooks. You can remote access if you want.
> 

945GME and 945GM should be same. I'll try if I can reproduce on 945GM.
Comment 7 Gordon Jin 2010-04-11 20:38:35 UTC
Peng, can you reproduce? If this only happens on this specific 945GM machine, I'm not going to strongly pursue this bug.
Comment 8 Gordon Jin 2010-05-09 22:44:52 UTC
decreasing priority, as we are moving the nightly testing from this 945GM to Pineview.
Comment 9 Jesse Barnes 2010-06-01 12:11:33 UTC
Does this bug still occur?
Comment 10 Li Peng 2010-06-01 18:45:03 UTC
Jesse, I will look at this bug, assign it to myself.
Comment 11 fangxun 2010-08-08 20:35:05 UTC
This problem have gone in current drm-intel-next git tip.
Comment 12 fangxun 2010-08-08 20:35:43 UTC
Mark it as verified.
Comment 13 Elizabeth 2017-10-06 14:54:12 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.