Bug 26770 - GSimpleAsyncResult source tags should be _async, not _finish
Summary: GSimpleAsyncResult source tags should be _async, not _finish
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Sjoerd Simons
QA Contact:
URL: http://git.collabora.co.uk/?p=user/ni...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-02-26 04:34 UTC by Will Thompson
Modified: 2010-10-04 09:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2010-02-26 04:34:01 UTC 
Wocky generally uses the _finish function as the source tag, but the GSimpleAsyncResult documentation says that the convention is to use the _async function.
Comment 1 Nicolas Dufresne 2010-09-23 11:27:57 UTC 
I've wrote a fix that can be found at:
http://git.collabora.co.uk/?p=user/nicolas/wocky.git;a=shortlog;h=refs/heads/source-tag
Comment 2 Will Thompson 2010-09-24 02:11:37 UTC 
> This makes Woky closer to GAsyncResult conventions

I hate to nitpick, but... maybe the commit message should spell the library's name correctly? :)
Comment 3 Nicolas Dufresne 2010-09-28 09:10:13 UTC 
(In reply to comment #2)
> I hate to nitpick, but... maybe the commit message should spell the library's
> name correctly? :)

My apologies, it's fixed now.
Comment 4 Will Thompson 2010-10-04 09:40:25 UTC 
ship it.

(though you'll want to rebase/cherry-pick to drop the patch before it in the branch.)
Comment 5 Nicolas Dufresne 2010-10-04 09:45:27 UTC 
(In reply to comment #4)
> ship it.
> 
> (though you'll want to rebase/cherry-pick to drop the patch before it in the
> branch.)
I just skipped that extra patch in the rebase since Sjoerd have implemented a similar fix recently.

Shipped.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.