I've brought Guillaume's PubSub branch up to date atop the freshly-merged data forms stuff, reviewed it, fixed my criticisms.
"Conventionally, the _async function is used as the source tag, not the _finish function." rly? AFAIK we always use the _finish function in Wocky. Branch looks good otherwise.
(In reply to comment #1) > "Conventionally, the _async function is used as the source tag, not the _finish > function." > rly? AFAIK we always use the _finish function in Wocky. Yes: gboolean g_simple_async_result_is_valid (GAsyncResult *result, GObject *source, gpointer source_tag); Third, source_tag is checked to ensure that it is equal to the source_tag argument given to g_simple_async_result_new() (which, by convention, is a pointer to the _async function corresponding to the _finish function from which this function is called). Merged; thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.