Bug 26170 - Tubes tests fail assertion about RequestableChannelClasses
Summary: Tubes tests fail assertion about RequestableChannelClasses
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: high major
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-01-22 07:47 UTC by Simon McVittie
Modified: 2010-01-22 08:06 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2010-01-22 07:47:35 UTC
With current master (5b5e88df16ac072f9119991f1e143e84268db540) I'm getting assertion failures in 5 tubes tests, all apparently because RequestableChannelClasses doesn't have the contents these tests want.

The assertion that fails is tests/twisted/tubes/tubetestutil.py:89:

    # muc tubes channel (old API)
    assert ({cs.CHANNEL_TYPE: cs.CHANNEL_TYPE_TUBES,
             cs.TARGET_HANDLE_TYPE: cs.HT_ROOM,
             },
             [cs.TARGET_HANDLE, cs.TARGET_ID
             ]
            ) in properties.get('RequestableChannelClasses'),\
                     properties['RequestableChannelClasses']

This appears to be because Tubes ROOM channels now have ChannelType in the allowed properties as well as in the fixed properties, which doesn't make sense.

This, in turn, seems to be because the array of allowed properties isn't correctly NULL-terminated. Patch soon.
Comment 1 Simon McVittie 2010-01-22 08:06:15 UTC
Fixed in git; did not affect a release, AIUI


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.