Bug 26120 - build: cleanups
Summary: build: cleanups
Status: RESOLVED NOTABUG
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-01-19 07:53 UTC by Felipe Contreras
Modified: 2013-09-17 17:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
configure.ac: modernize a bit (1.72 KB, patch)
2010-01-19 07:53 UTC, Felipe Contreras
Details | Splinter Review
Automatic version generation (2.03 KB, patch)
2010-01-19 07:53 UTC, Felipe Contreras
Details | Splinter Review
Trivial cleanups (670 bytes, patch)
2011-09-19 15:34 UTC, Felipe Contreras
Details | Splinter Review
Automatic version generation (2.42 KB, patch)
2011-09-19 15:35 UTC, Felipe Contreras
Details | Splinter Review
Automatic version generation (2.52 KB, patch)
2011-11-21 11:08 UTC, Will Thompson
Details | Splinter Review

Description Felipe Contreras 2010-01-19 07:53:48 UTC
A few patches to improve the build.
Comment 1 Felipe Contreras 2010-01-19 07:53:50 UTC
Created attachment 32717 [details] [review]
configure.ac: modernize a bit

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Comment 2 Felipe Contreras 2010-01-19 07:53:52 UTC
Created attachment 32718 [details] [review]
Automatic version generation

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Comment 3 Jonny Lamb 2010-01-25 07:49:50 UTC
(In reply to comment #1)
> Created an attachment (id=32717) [details]
> configure.ac: modernize a bit

Merged and released in 0.3.3.

(In reply to comment #2)
> Created an attachment (id=32718) [details]
> Automatic version generation

Will and I don't see the point in this, so I didn't merge it.

Thanks for your patches.
Comment 4 Felipe Contreras 2010-01-25 08:10:03 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=32718) [details] [details]
> > Automatic version generation
> 
> Will and I don't see the point in this, so I didn't merge it.

Try it some time. Making a release is just one command: git tag.

Besides, suppose you looking at a debug log and see something like this:
started version 0.3.2 (telepathy-glib version 0.9.2)

Versus:
started version 0.3.2-2maemo1 (telepathy-glib version 0.9.2)

Or even:
started version 0.3.2-10-g2be75d5 (telepathy-glib version 0.9.2)

> Thanks for your patches.

Thanks to you.
Comment 5 Will Thompson 2010-01-25 08:14:41 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Created an attachment (id=32718) [details] [details] [details]
> > > Automatic version generation
> > 
> > Will and I don't see the point in this, so I didn't merge it.
> 
> Try it some time. Making a release is just one command: git tag.
> 
> Besides, suppose you looking at a debug log and see something like this:
> started version 0.3.2 (telepathy-glib version 0.9.2)
> 
> Versus:
> started version 0.3.2-2maemo1 (telepathy-glib version 0.9.2)
> 
> Or even:
> started version 0.3.2-10-g2be75d5 (telepathy-glib version 0.9.2)

I'm in favour of sticking the git revision into stuff built from Git snapshots. Is this actually updated on commit, or only when re-running autogen?

Also, the patch breaks the stuff 10 lines down that makes loads of compiler warnings fatal for non-releases.
Comment 6 Felipe Contreras 2010-01-25 08:36:01 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Or even:
> > started version 0.3.2-10-g2be75d5 (telepathy-glib version 0.9.2)
> 
> I'm in favour of sticking the git revision into stuff built from Git snapshots.
> Is this actually updated on commit, or only when re-running autogen?

Only when running autogen. This is exactly what they do in autoconf itself, and a bunch of GNOME packages.

I use a different method in my own packages that keeps it always up to date but I don't think you want that.

> Also, the patch breaks the stuff 10 lines down that makes loads of compiler
> warnings fatal for non-releases.

Ah, right, I didn't see that. If you are still interested I can cook something up.
Comment 7 Will Thompson 2010-01-25 09:00:53 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > I'm in favour of sticking the git revision into stuff built from Git snapshots.
> > Is this actually updated on commit, or only when re-running autogen?
> 
> Only when running autogen. This is exactly what they do in autoconf itself, and
> a bunch of GNOME packages.

Hmm. I wonder if more-specific but stale information is worse than less-specific but accurate information.

> I use a different method in my own packages that keeps it always up to date but
> I don't think you want that.

Hmm, what's your method, out of interest?
Comment 8 Felipe Contreras 2010-01-25 10:12:43 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> Hmm. I wonder if more-specific but stale information is worse than
> less-specific but accurate information.

Good point. It might not be particularly useful on personal environments, but it might on distributions.

> > I use a different method in my own packages that keeps it always up to date but
> > I don't think you want that.
> 
> Hmm, what's your method, out of interest?

I always rebuild the files that actually use the version (src/main.o). However, I use plain Makefiles, so it's easier to get the version each time I run 'make'.
Comment 9 Felipe Contreras 2011-09-19 15:34:04 UTC
Created attachment 51375 [details] [review]
Trivial cleanups

Trivial stuff.
Comment 10 Felipe Contreras 2011-09-19 15:35:26 UTC
Created attachment 51376 [details] [review]
Automatic version generation

Here's a new version of the patch that sets correctly the release variable.

It would be trivial to change 0.5.0-4-gd8d75d9 to 0.5.0-4-git, or whatever.
Comment 11 Will Thompson 2011-11-21 09:29:43 UTC
Comment on attachment 51375 [details] [review]
Trivial cleanups

Review of attachment 51375 [details] [review]:
-----------------------------------------------------------------

Committed, thanks.
Comment 12 Will Thompson 2011-11-21 11:08:00 UTC
Created attachment 53747 [details] [review]
Automatic version generation

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Comment 13 Will Thompson 2011-11-21 11:12:06 UTC
I had to tweak your patch a little: dist-hook is also defined in tools/telepathy.am so I got warnings about it being redefined, and there was a syntax error in configure.ac.

This seems pretty nifty, although I had to remember to re-run autogen.sh after creating a test tag (whereas, at present, the act of bumping the version number triggers that). So it doesn't cut a step out of distcheck (and actually I suspect it would be quite easy to release a tarball with the wrong version number stamped on the outside). I'll have a think about how to tweak 'make maintainer-make-release' to, rather than creating a tag after the build has succeeded, check that autogen's been rerun if necessary.
Comment 14 Simon McVittie 2013-09-17 17:47:48 UTC
Sorry, I don't think this is going to be merged.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.