Bug 25600 - TpAccount secretly adds gio >= 2.22 dep
Summary: TpAccount secretly adds gio >= 2.22 dep
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: high normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Keywords: patch
Depends on:
Blocks: 24209
  Show dependency treegraph
Reported: 2009-12-11 14:19 UTC by Jonny Lamb
Modified: 2009-12-12 10:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Jonny Lamb 2009-12-11 14:19:33 UTC
Somewhere between GLib versions 2.20 and 2.22, this happened:


(2.22 is the first release for this commit to appear in.)

TpAccount uses the const version of this, so fails to build on < 2.22 with:

    account.c: In function ‘tp_account_prepare_async’: account.c:2598: error: passing argument 2 of ‘g_simple_async_result_set_from_error’ discards qualifiers from pointer target type

We can either bump the dep of gio to >= 2.22, or cast these const GError*s to GError* and revert that when we do depend on 2.22.

It's up to you.
Comment 1 Simon McVittie 2009-12-12 08:50:51 UTC
For 0.9/0.10 please apply the non-const casts; I don't think we want higher-than-necessary dependencies for an imminent stable release (so I've marked this as a 0.10 blocker). After 0.10, we should depend on the newer GIO for 0.11.x.
Comment 2 Jonny Lamb 2009-12-12 08:59:21 UTC
Okay, turns out I had already done this as part of 5620910fe5, but the recent additions to these files had not.

Czech out my branch.
Comment 3 Simon McVittie 2009-12-12 10:09:45 UTC
review+. Ship it (to the Czech Republic, if you so wish).
Comment 4 Jonny Lamb 2009-12-12 10:33:25 UTC
(In reply to comment #3)
> review+. Ship it (to the Czech Republic, if you so wish).

< merged lol >
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.