Bug 25542 - [transet] Gentoo QA Notice: incompatible implicit declaration of built-in function 'memcpy'
Summary: [transet] Gentoo QA Notice: incompatible implicit declaration of built-in fun...
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: git
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Keith Packard
QA Contact: Xorg Project Team
Whiteboard: 2011BRB_Reviewed
Keywords: patch
Depends on:
Reported: 2009-12-09 13:19 UTC by walch.martin
Modified: 2015-05-08 05:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description walch.martin 2009-12-09 13:19:27 UTC
When installing transset on Gentoo (amd64), portage complains about a compiler warning (gcc 4.4.2):

QA Notice: Package has poor programming practices which may compile fine but exhibit random runtime failures.
* transSet.c:68: warning: incompatible implicit declaration of built-in function 'memcpy'

This seems to be resolved easily with an additional include of string.h:

--- a/transSet.c        2009-12-09 22:05:07.000000000 +0100    
+++ b/transSet.c        2009-12-09 22:05:07.000000000 +0100
@@ -13,6 +13,7 @@
 #include <X11/Xatom.h>
 #include "dsimple.h"
 #include <stdlib.h>
+#include <string.h>

 Window target_win;

There is another compiler warning (without Gentoo QA notice) in dsimple.c:

dsimple.c: In function 'Window_With_Name':
dsimple.c:478: warning: comparison between signed and unsigned integer expressions

This one also seems to have a simple fix

--- a/dsimple.c 2009-12-09 22:10:02.000000000 +0100
+++ b/dsimple.c 2009-12-09 22:11:26.000000000 +0100
@@ -464,8 +464,7 @@
      char *name;
        Window *children, dummy;
-       unsigned int nchildren;
-       int i;
+       unsigned int i, nchildren;
        Window w=0;
        char *window_name;
Comment 1 Corbin Simpson 2011-09-14 04:34:32 UTC
Comment 2 Jeremy Huddleston Sequoia 2011-10-04 23:59:25 UTC
Should this just be closed?  Where is this even located?   Google says you're 
partially to blame, Keith, so over to you to do with or close as you like.
Comment 3 Alan Coopersmith 2011-10-06 18:50:32 UTC
(In reply to comment #2)
> Where is this even located?

Comment 4 Alan Coopersmith 2015-05-08 05:53:54 UTC
Transset has now been added to the xorg/apps git repos.

Problem 1 was fixed in the import of changes from Daniel Forchheimer:

Problem 2 was still in the code - I've pushed a fix for it to git now:

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.