Bug 25306 - 'configure' of 'dbus-1.2.16' apparently ignores paths to 'gettext'
Summary: 'configure' of 'dbus-1.2.16' apparently ignores paths to 'gettext'
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.2.x
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-11-26 12:06 UTC by Sergei Steshenko
Modified: 2011-01-14 07:19 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
autogenerated script used to run 'configure' (1.72 KB, application/octet-stream)
2009-11-26 12:06 UTC, Sergei Steshenko
Details
Remove vestigial support for $INTLLIBS (1.25 KB, patch)
2011-01-06 10:23 UTC, Simon McVittie
Details | Splinter Review

Description Sergei Steshenko 2009-11-26 12:06:31 UTC
Created attachment 31488 [details]
autogenerated script used to run 'configure'

I run 'configure' of 'dbus-1.2.16' using the attached autogenerated 'config_wrapper.sh' script. Please note the script contains:

/mnt/sdb8/sergei/AFSWD_debug/install/gettext-0.17/bin in PATH;
/mnt/sdb8/sergei/AFSWD_debug/install/gettext-0.17/lib in LD_LIBRARY_PATH;
-L/mnt/sdb8/sergei/AFSWD_debug/install/gettext-0.17/lib in LDFLAGS;
-I/mnt/sdb8/sergei/AFSWD_debug/install/gettext-0.17/include in CPPFLAGS .

Still, at the bottom of 'configure' screen output I see:

"
                    D-Bus 1.2.16
                  ==============

        prefix:                   /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16
        exec_prefix:              ${prefix}
        libdir:                   /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/lib
        libexecdir:               /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/libexec
        bindir:                   /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/bin
        sysconfdir:               /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/etc
        localstatedir:            /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/var
        datadir:                  /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/share
        source code location:     .
        compiler:                 gcc
        cflags:                   -ffunction-sections -fdata-sections -g -O2 -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wdeclaration-after-statement -fno-common -Wno-unused -Wno-sign-compare -Wno-pointer-sign -Wno-format -fno-strict-aliasing
        cppflags:                 -I/mnt/sdb8/sergei/AFSWD_debug/install/expat-2.0.1/include -I/mnt/sdb8/sergei/AFSWD_debug/install/gettext-0.17/include -I/mnt/sdb8/sergei/AFSWD_debug/install/libiconv_pre-1.11/include -I/mnt/sdb8/sergei/AFSWD_debug/install/libxml2-2.7.6/include/libxml2 -I/mnt/sdb8/sergei/AFSWD_debug/install/zlib-1.2.3/include
        cxxflags:                 -g -O2
        64-bit int:               long long
        32-bit int:               int
        16-bit int:               short
        Doxygen:                  no
        xmlto:                    no

        Maintainer mode:          no
        gcc coverage profiling:   no
        Building unit tests:      yes
        Building verbose mode:    no
        Building assertions:      yes
        Building checks:          yes
        Building SELinux support: no
        Building inotify support: yes
        Building dnotify support: no
        Building kqueue support:  no
        Building X11 code:        yes
        Building Doxygen docs:    no
        Building XML docs:        no
        Building cache support:   yes
        Gettext libs (empty OK):
        Using XML parser:         expat
        Init scripts style:       none
        Abstract socket names:    yes
        System bus socket:        /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/var/run/dbus/system_bus_socket
        System bus address:       unix:path=/mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/var/run/dbus/system_bus_socket
        System bus PID file:      /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/var/run/dbus/pid
        Session bus socket dir:   /tmp
        Console auth dir:         /var/run/console/
        Console owner file:       no
        Console owner file path:
        System bus user:          messagebus
        Session bus services dir: /mnt/sdb8/sergei/AFSWD_debug/install/dbus-1.2.16/share/dbus-1/services
        'make check' socket dir:  /tmp
",

specifically:
"
Gettext libs (empty OK):
".

I also do not see that 'configure' checks 'gettext' presence, i.e. I do not see
"Checking for" related to 'gettext'.
Comment 1 Simon McVittie 2011-01-06 10:22:36 UTC
Mentions of INTLLIBS in configure.ac seem to be vestigial: it used to be set by AM_GLIB_GNU_GETTEXT for dbus-glib, but dbus-glib is no longer part of the dbus tarball.

tools/dbus-viewer.c is the only thing left in the dbus tarball that can be internationalized, and it uses GLib rather than using gettext directly.
Comment 2 Simon McVittie 2011-01-06 10:23:08 UTC
Created attachment 41716 [details] [review]
Remove vestigial support for $INTLLIBS

We no longer call AM_GLIB_GNU_GETTEXT or use gettext directly.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=25306
Comment 3 Simon McVittie 2011-01-14 07:19:01 UTC
15:14 < wjt> smcv: tmp looks fine
15:15 < wjt> smcv: as does trivia

Fixed in git for 1.4.4 or 1.5.0.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.