Bug 25216 - [PATCH] Fix a small potential memory leak in ProcRotateProperties
Summary: [PATCH] Fix a small potential memory leak in ProcRotateProperties
Status: RESOLVED INVALID
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All All
: low trivial
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-11-21 14:54 UTC by Jesse Adkins
Modified: 2010-04-08 03:56 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for the leak (805 bytes, patch)
2009-11-21 14:54 UTC, Jesse Adkins
no flags Details | Splinter Review

Description Jesse Adkins 2009-11-21 14:54:05 UTC
I'm guessing that this leak is unlikely, though it's still possible.
Comment 1 Jesse Adkins 2009-11-21 14:54:59 UTC
Created attachment 31376 [details] [review]
Patch for the leak

Second try at adding the attachment.
Comment 2 Alan Coopersmith 2009-11-22 16:09:08 UTC
Patches are generally reviewed on the mailing list, not bugzilla.
See: http://www.x.org/wiki/Development/Documentation/SubmittingPatches
Comment 3 Corbin Simpson 2010-04-08 03:56:43 UTC
Closing; the out label already contains the xfree() calls, so you'll actually double-xfree() with this patch.

In the future, to expedite patch review, please send patches to the mailing list. Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.