Bug 25102 - dmx "auto" change causes build error
Summary: dmx "auto" change causes build error
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.5 (2009.10)
Hardware: All All
: medium normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
Keywords: regression
Depends on:
Blocks: xserver-1.7.x
  Show dependency treegraph
Reported: 2009-11-15 10:47 UTC by Adrian Bunk
Modified: 2009-11-26 20:59 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

0001-Move-xdmxconfig-modules-into-DMX-conditionals-25102.patch (1.75 KB, patch)
2009-11-16 15:33 UTC, Peter Hutterer
no flags Details | Splinter Review

Description Adrian Bunk 2009-11-15 10:47:14 UTC
Commit 232d4351 (dmx: Make description match default option.) changed the default for --enable-dmx from "no" to "auto".

This causes the following build error:

<--  snip  -->

checking for DMXMODULES... yes
checking whether to build Xdmx DDX... yes
checking linux/input.h usability... yes
checking linux/input.h presence... yes
checking for linux/input.h... yes
checking linux/keyboard.h usability... yes
checking linux/keyboard.h presence... yes
checking for linux/keyboard.h... yes
checking for XDMXCONFIG_DEP... configure: error: Package requirements (xaw7 xmu xt xpm x11) were not met:

No package 'xaw7' found
No package 'xpm' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables XDMXCONFIG_DEP_CFLAGS
and XDMXCONFIG_DEP_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

make: *** [__matrix_build] Error 1

<--  snip  -->

Either the dependencies for XDMXCONFIG_DEP have to be added to DMXMODULES or failed XDMXCONFIG_DEP should cause xdmxconfig to not be built.

Other variables like $LIBDMX seem to have a similar problem of not being in DMXMODULES.
Comment 1 Peter Hutterer 2009-11-16 15:33:18 UTC
Created attachment 31244 [details] [review]

Does this fix the issue for you?
Comment 2 Adrian Bunk 2009-11-16 17:43:46 UTC
(In reply to comment #1)
> Created an attachment (id=31244) [details]
> 0001-Move-xdmxconfig-modules-into-DMX-conditionals-25102.patch
> Does this fix the issue for you?

Thanks, this fixes it.
Comment 3 Peter Hutterer 2009-11-26 20:59:04 UTC
pushed as commit 8806375ed72a3cd465fe0a49ead079a334accd6b

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.