Bug 2478 - xdm should support echoing * for password entry
Summary: xdm should support echoing * for password entry
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xdm (show other bugs)
Version: 6.8.0
Hardware: x86 (IA32) Linux (All)
: high enhancement
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2005-02-05 16:48 UTC by Eric Brown
Modified: 2010-03-15 17:46 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:

patch in git format (12.68 KB, patch)
2009-09-22 06:30 UTC, Georgy Shepelev
no flags Details | Splinter Review
Patch for just the echoPasswd option (7.21 KB, patch)
2009-09-22 16:09 UTC, Alan Coopersmith
no flags Details | Splinter Review
adding an utf8 support in messages; echoPasswd option is checked now in Login.c (11.91 KB, patch)
2009-10-05 21:30 UTC, Georgy Shepelev
no flags Details | Splinter Review
adding documentation of 'echoPasswd' option to the man page (1.08 KB, patch)
2009-12-08 22:37 UTC, Georgy Shepelev
no flags Details | Splinter Review
fixed patch (6.46 KB, patch)
2009-12-09 02:58 UTC, Georgy Shepelev
no flags Details | Splinter Review
Adding utf8-support in all prompt-/greeting-messages (1.26 KB, patch)
2009-12-09 03:01 UTC, Georgy Shepelev
no flags Details | Splinter Review

Description Eric Brown 2005-02-05 16:48:09 UTC
xdm looks ugly be default because it does not have a background color set.  I
propose that the default Xsetup_0 file come with the background color set to
black by putting this in the file:

/usr/X11R6/bin/xsetroot -solid black

Now, instead of those confusing gray lines, you get a nice black background.
Comment 1 Erik Andren 2006-04-22 18:38:26 UTC
This is not a bug but a feature.
Comment 2 Donnie Berkholz 2006-04-23 03:18:19 UTC
I think that means the severity should be changed to enhancement, rather than
resolving the bug altogether.
Comment 3 Daniel Stone 2007-02-27 01:25:20 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 4 Georgy Shepelev 2009-09-17 06:16:01 UTC
Like so?

I've made a little improovement: password can be echoed with asterisks. This feature can be enabled in Xresource file by adding line 'xlogin*echoPasswd: true'. The default value is false.

The whole widget borders width could not be set to zero. This 'bug' was fixed.

There are two patches:
1) diff -u ...: http://files.mail.ru/cgi-bin/files/fdownload?id=64537576
2) diff -c ...: http://files.mail.ru/cgi-bin/files/fdownload?id=64537561

I want to make more improovements. Todo:
1) transparency support
2) support utf-8 string in welcome messages
Comment 5 Georgy Shepelev 2009-09-17 06:18:09 UTC
Sorry, wrong links

Comment 6 Alan Coopersmith 2009-09-17 17:30:50 UTC
I was just about to close this bug actually as not being necessary now
that Xorg starts with black root by default.

Adding an option to show stars is something I've thought about but never
had time to tackle - however, your patches seem to be reversed, and against
the original 1.1.8 sources, and I can't tell what the difference is between
the two patch files, as they seem to have some of the same changes in.
I'm about to release 1.1.9, but patches are preferred against git master,
in git format-patch format when possible, as described at:

Attributions of who added what should be done in the git history, not the
source code (xdm unfortunately has some bad examples there that need to be
cleaned up).

Please use the bugzilla attachment mechanism to post them or mail them to
the list instead of hosting on another site that may delete them before
someone gets a chance to apply (and which has instructions that at least
I can't read).   
Comment 7 Georgy Shepelev 2009-09-22 06:30:22 UTC
Created attachment 29756 [details] [review]
patch in git format
Comment 8 Alan Coopersmith 2009-09-22 16:09:59 UTC
Created attachment 29780 [details] [review]
Patch for just the echoPasswd option

Thanks.  I've split this into multiple parts for easier review.   
I pushed the simplest one to git master already - the zero framewidth fix:

I dropped all the formatting/style changes, especially the ones that made
the new code not match the existing code (while we can debate which style
is best, mixing different styles inconsistently in the same code is 
definitely worse than any single style), and have attached a patch showing
the remaining changes still needing review.

At first glance the changes seem mostly reasonable, though I'll need to 
take a closer look still.   We'll need to add documentation of the 
"EchoPassword" option to the man page, and I'm wondering if a better name
for the user option would make it sound less like it's echoing the actual

I'm not sure about the changes to greeter/greet.c - setting the prompts to
username and password before PAM prompts for them violates the PAM
conversation design, and since the "not shown" flag is there, I don't see
what the point is.   I'd also rather handle the echo_passwd option check
in Login.c itself, instead of in the PAM specific logic, so we don't have
to modify all the different authentication methods (since I can't test all
of them myself).
Comment 9 Georgy Shepelev 2009-10-05 21:30:15 UTC
Created attachment 30103 [details] [review]
adding an utf8 support in messages; echoPasswd option is checked now in Login.c

Some screenshots
Comment 10 Georgy Shepelev 2009-12-08 22:37:13 UTC
Created attachment 31868 [details] [review]
adding documentation of 'echoPasswd' option to the man page
Comment 11 Georgy Shepelev 2009-12-09 02:58:49 UTC
Created attachment 31874 [details] [review]
fixed patch

xdm: Adding an option to show stars instead of the password itself.
xdm: The behaviour can be controlled via 'xlogin*echoPasswd' option
xdm: in Xresource file. The default option value is 'false'.
Comment 12 Georgy Shepelev 2009-12-09 03:01:58 UTC
Created attachment 31875 [details] [review]
Adding utf8-support in all prompt-/greeting-messages
Comment 13 Georgy Shepelev 2010-01-27 22:40:27 UTC
Hi. What's up with this patches? :)
Comment 14 Alan Coopersmith 2010-03-15 17:46:11 UTC
I've been busy at work getting our spring distro release completed and
haven't had time to look at them until now.

I've applied the first two, with some formatting changes, though I'm also
working on a followup patch to improve things.

I don't understand why the third patch is necessary, but as this bug has
already gone way beyond what it's described as, I'm closing it as fixed.

Please feel free to open new bugs for new patches, with more description,
such as explaining why narrowing the character sets supported by Xft from
all 8-bit charsets to just UTF-8 is an improvement.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.