Bug 24623 - [PATCH] xf86-input-elographics: Add support for GeneralTouch serial touchscreens
Summary: [PATCH] xf86-input-elographics: Add support for GeneralTouch serial touchscreens
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/elographics (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2009-10-19 07:58 UTC by Ivan Afonichev
Modified: 2009-12-17 17:13 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

git patch (2.04 KB, patch)
2009-10-19 07:58 UTC, Ivan Afonichev
no flags Details | Splinter Review
Remove unnecessary comments (1.55 KB, patch)
2009-12-17 01:20 UTC, Ivan Afonichev
no flags Details | Splinter Review

Description Ivan Afonichev 2009-10-19 07:58:54 UTC
Created attachment 30557 [details] [review]
git patch

GeneralTouch touchscreen serial controllers uses the same protocol as Elographics touchscreens, but there is no initialization needed.

This patch was developed for Linux powered Kiosk that was "participating" in Software Freedom Day'2009 in Saratov, Russia


Comment 1 Peter Hutterer 2009-12-07 22:34:53 UTC
Thanks for the patch and sorry about the delay. Things are rather busy here.

I noticed that the gist of the patch is to avoid the error detection for the elographics hardware. While this may work for this particular touchscreen, we loose out if the screen is neither elographics nor a GeneralTouch.

is there any way of detecting if the screen is a GeneralTouch screen?
Comment 2 Ivan Afonichev 2009-12-08 00:42:11 UTC
I think if screen is neither elographics nor a GeneralTouch we wouldn't guarantee user it's working.

I'll test how Xorg with patched xf86-input-elographics is working with no touchscreen attached later on this week.(I think other pointing device such as mouse should work normally)
Comment 3 Ivan Afonichev 2009-12-14 02:52:33 UTC
I test it 2009-12-11. Everything is ok. USB and PS/2 mice are working good also when driver is loaded and touchscreen not attached. And there was no abnormal activity of X11 or something else.
Comment 4 Peter Hutterer 2009-12-16 17:22:42 UTC
one change I'd like you to make in this patch please:
instead of using comments to deactivate the code, just remove it. there's no reason to leave it there if we're not going to call it anyway.

when you re-submit the patch please make sure you sign off the patch, I'll push it to once it's attached here. Thanks again for the patch.
Comment 5 Ivan Afonichev 2009-12-17 01:20:24 UTC
Created attachment 32140 [details] [review]
Remove unnecessary comments

patch to be pushed after previous patch
Comment 6 Peter Hutterer 2009-12-17 17:12:53 UTC
Pushed as ac5366d6e1f26e6ceef3d062ab7df301d623cf54, thanks for the patch!
Comment 7 Peter Hutterer 2009-12-17 17:13:26 UTC
i forgot to mention - i squashed the two patches into a single commit before pushing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.