Created attachment 29853 [details] [review]
[PATCH] Add missing INSTALL file.
While browsing tinderbox build http://tinderbox.freedesktop.org/builds/2009-09-25-0022/, I noticed app/xclock failed upon checkout because untracked file INSTALL would be overwritten.
This file is missing in git, so it gets generated:
"Makefile.am: installing `./INSTALL'"
It's now a new and untracked file which gets in the way of future git operations.
I provided a patch to add the generated INSTALL file in git.
It's better to add the INSTALL file to .gitignore, I've done just that with 30db8ad3c045a4fbcff171435bb8e56ed792a5ec.
INSTALL is autogenerated and one of the general rules is to not put generated files under versioning control.
Thanks for the report, I'd have missed that one.
Then I am really confused...
The wiki modules guidelines state that all components must have "foreign" specified. This suppresses the generation of INSTALL and COPYING files.
Out of 268 modules, 152 are specifying foreign in either configure.ac (90) or Makefile.am (62). There are 164 INSTALL (mostly zero byte) files checked-in git but only 5 are git ignored.
Your patch will work and fix the immediate build problem. We can worry later about which is the preferred method and proceed to it's implementation.
Sometimes the rules are written after the code, and sometimes the maintainers aren't aware of the rules. You've just found another janitor job :)