Created attachment 29651 [details] [review]
use different image_from_pict function call
Without the attached patch I get a "too many arguments" error from gcc for this Xorg function: image_from_pict.
The patch allows the xf86-video-intel driver to compile correctly.
Thanks for reporting this issue and providing the patch.
Unfortunately, I'm not sure what we should do here. The change in the X server
that triggered the breakage in the driver is the following commit:
Author: Søren Sandmann Pedersen <email@example.com>
Date: Sat Jun 13 10:28:21 2009 -0400
Fix clipping when windows are used as sources
The new clipping rules:
- client clips happen after transformation
- pixels unavailable due to the hierarchy are undefined
The first one is implemented in pixman; the second one is realized by
making a copy of window sources (to prevent out-of-bounds access).
Both before and after this commit, the X server advertised a version of
So there are some X servers of version "220.127.116.11" that have the two-argument
image_from_pict and other X servers also of version "18.104.22.168" that have the
three-argument version. We just can't win when interfaces change without
corresponding changes to version numbers.
Were you building from an X server git checkout? These days an X server
git checkout gives a version number of 22.214.171.124 so it should work just fine.
Or were you perhaps building from some tar file release of "126.96.36.199"?
If there's something out there like that, then we probably should change
the driver to work with it.
Let me know,
no 188.8.131.52 tarball was published, so I think we can go ahead and WONTFIX this one.