Bug 23801 - Generated libcomp.pc in git appears to have no purpose
Summary: Generated libcomp.pc in git appears to have no purpose
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: git master
Hardware: x86-64 (AMD64) Linux (All)
: lowest trivial
Assignee: Gaetan Nadon
QA Contact: Søren Sandmann Pedersen
URL:
Whiteboard:
Keywords: janitor
Depends on:
Blocks:
 
Reported: 2009-09-08 17:20 UTC by Gaetan Nadon
Modified: 2009-09-09 11:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] Remove unused generated libcomp.pc #23801 (692 bytes, patch)
2009-09-08 17:23 UTC, Gaetan Nadon
Details | Splinter Review

Description Gaetan Nadon 2009-09-08 17:20:40 UTC
Typically generated files are not checked in git, but there could be exceptions. This file is not installed in lib/pkgconfig so it cannot be seen by any other module. 

It's not a big issue, but it will hinder some work in the future because it is the only .pc file in git in X.Org . I am including a patch to remove it, if it is the right course of action. Feel free to keep it if it has some purpose that isn't obvious.

I noticed Debian distro removed it:
http://article.gmane.org/gmane.linux.debian.devel.x/59979
Comment 1 Gaetan Nadon 2009-09-08 17:23:11 UTC
Created attachment 29343 [details] [review]
[PATCH] Remove unused generated libcomp.pc #23801
Comment 2 Søren Sandmann Pedersen 2009-09-09 11:40:45 UTC
No, this file dates from the very early days of pixman, where I considered calling it libcomp. It has not ever served a purpose.

Fixed in fefe2a5d24591846281bb9bf0e85d42822e1716e.

Thanks,



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.