Bug 23780 - use TpDebugSender
Summary: use TpDebugSender
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Keywords: patch
Depends on:
Reported: 2009-09-07 08:50 UTC by Jonny Lamb
Modified: 2009-11-09 13:13 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Description Jonny Lamb 2009-09-07 08:50:45 UTC
My branch has a first attempt. It's very likely I might have misunderstood some purple debugging stuff though. It /appears/ to work though.
Comment 1 Will Thompson 2009-11-09 13:13:21 UTC
I reviewed Mike's updated version of this branch.

In haze_debug():

+    domain = g_strdup_printf ("%s/%s", G_LOG_DOMAIN, "haze");

Dupping this for every debug message is unnecessary:

    #define LOG_DOMAIN (G_LOG_DOMAIN "/haze")


My purple working copy must be really out of date, I can't see any uses of critical. I trust your judgement that criticals are critical enough to crash on. :-)

I've fixed the first issue, rebased to remove some spurious merges from Jonny's history, and merged. It'll be in 0.3.3. Thanks!

commit a3660efd0090f24280a540b1a87015ffdd312b84
Merge: dee146a 31af13f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date:   Mon Nov 9 21:11:45 2009 +0000

    Merge branch 'debug'

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.