Created attachment 29166 [details] [review]
patch to fix the problem
SIMD=n, NEON=y resulted in a build error due to pixman-arm-neon.c
Let pixman-arm-simd.c be basically empty when SIMD is disabled and
NEON is enabled.
That's a general problem, but hits especially when building
Ugh, this looks way too complex for what it does.
If keeping a fallback to ARMv6 code has to be preserved no matter what, maybe just an '#ifdef USE_ARM_SIMD' in pixman-arm-neon.c could do this in a much cleaner way?
I applied the following patch after all: http://bugs.freedesktop.org/attachment.cgi?id=29109
The end result is the same and thumb-2 build problem is fixed.
Not building 'pixman-arm-simd.c' source file when 'arm-simd' is disabled by configure is not a problem as such. Quite the contrary, compiling an empty file with a stub function is not a very good looking workaround.
(In reply to comment #2)
> I applied the following patch after all:
> The end result is the same and thumb-2 build problem is fixed.
> Not building 'pixman-arm-simd.c' source file when 'arm-simd' is disabled by
> configure is not a problem as such.
After reading _pixman_choose_implementation() I agree with you.