Created attachment 28337 [details] [review] Document GetConnectionUnixProcessID in the spec GetConnectionUnixProcessID isn't mentioned in the D-Bus specification (although GetConnectionUnixUser is). The attached patch adds it.
Created attachment 32554 [details] [review] Document GetConnectionUnixProcessID in the spec
Created attachment 32555 [details] [review] Fix a broken <xref/>
Created attachment 32556 [details] [review] Document ListQueuedOwners in the spec
Matthew told me about ListQueuedOwners today. Hey, there's a method that makes queueing useful! So let's document it too. Patches attached; also viewable in gitweb at the attached URL.
Review of attachment 32554 [details] [review]: ::: doc/dbus-specification.xml @@ +4098,3 @@ + As a method: + <programlisting> + UINT32 GetConnectionUnixProcessID (in STRING connection_name) in STRING bus_name, or unique_name, might be clearer? @@ +4114,3 @@ + <entry>0</entry> + <entry>STRING</entry> + <entry>Name of the connection to query</entry> Does this work for well-known names too? I'd say "Unique bus name of the...", or "Unique or well-known bus name of the...", depending. @@ +4133,3 @@ + <entry>0</entry> + <entry>UINT32</entry> + <entry>unix process id</entry> Unix @@ +4138,3 @@ + </tgroup> + </informaltable> + Returns the unix process ID of the process connected to the server. If Unix @@ +4140,3 @@ + Returns the unix process ID of the process connected to the server. If + unable to determine it, a + <literal>org.freedesktop.DBus.Error.Failed</literal> error is returned. Since the Failed error is the catch-all, it'd be reasonable to add something more specific later, so I'd loosen this to "an error is returned". It's probably worth saying "...unable to determine it (for instance because the process is not on the same machine as the bus daemon), ..."
Review of attachment 32555 [details] [review]: ::: doc/dbus-specification.xml @@ +3350,3 @@ <para> Match rules are added using the AddMatch bus method + (see <xref linkend="bus-messages-add-match"/>). Rules are Ship it.
Review of attachment 32556 [details] [review]: ::: doc/dbus-specification.xml @@ +3351,3 @@ + <entry>0</entry> + <entry>STRING</entry> + <entry>The name to query</entry> "The well-known bus name to..." perhaps? @@ +3370,3 @@ + <entry>0</entry> + <entry>ARRAY of STRING</entry> + <entry>The connections currently queued for the name</entry> "The unique bus names of connections..."?
Created attachment 36329 [details] [review] Document GetConnectionUnixProcessID in the spec
Created attachment 36330 [details] [review] Document ListQueuedOwners in the spec
Created attachment 36331 [details] [review] Clarify GetConnectionUnixUser documentation. (This makes it match the freshly-documented GetConnectionUnixProcessID.)
Review of attachment 36329 [details] [review]: I approve.
Review of attachment 36330 [details] [review]: I approve.
Review of attachment 36331 [details] [review]: I approve.
Thanks, merged to master.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.