Bug 22854 - Versioning flags not set for new API
Summary: Versioning flags not set for new API
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://cgit.freedesktop.org/~smcv/dbu...
Keywords: patch
Depends on:
Reported: 2009-07-20 09:30 UTC by Daniel Macks
Modified: 2011-06-02 05:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Remind maintainers to update the libtool versioning (754 bytes, patch)
2011-04-20 08:45 UTC, Simon McVittie
Details | Splinter Review

Description Daniel Macks 2009-07-20 09:30:44 UTC
Going from dbus-glib-0.80 to 0.82, new public function dbus_g_connection_unregister_g_object was added. However, the libtool versioning flags were not changed. Both releases have configure.ac that states the same versioning (along with documentation instructing you to change it):

>## increment if the interface has additions, changes, removals.
>## increment if any interfaces have been added; set to 0
>## if any interfaces have been changed or removed. removal has
>## precedence over adding, so set to 0 if both happened.

Using lib versioning properly allows downstream packagers to handle dependencies more easily (don't need to analyze the whole public header set to decide compatibility) and gives end-users better feedback if they use a version "too old" to have a symbol they need (tells what libversion provides it, not just "symbol not found").
Comment 1 Simon McVittie 2011-04-20 08:44:48 UTC
We can't fully fix this til the next release, but it'd be worth adding a reminder to the cheat-sheet in HACKING.
Comment 2 Simon McVittie 2011-04-20 08:45:13 UTC
Created attachment 45866 [details] [review]
Remind maintainers to update the libtool versioning
Comment 3 Guillaume Desmottes 2011-05-30 07:23:30 UTC
Review of attachment 45866 [details] [review]:

looks good.
Comment 4 Simon McVittie 2011-05-30 07:43:41 UTC
Thanks; HACKING fixed in git for 0.94 based on Guillaume's review + no objections from the reviewer group, and the actual libtool versioning will be fixed in 0.94.
Comment 5 Simon McVittie 2011-06-02 05:11:41 UTC
Fixed in 0.94 (I bumped the CURRENT and AGE even though nothing was actually added in 0.94, to compensate for the opposite error in 0.82)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.