Bug 22840 - [PATCH] dix: xserver "make dist" fails due to eventconvert.h
Summary: [PATCH] dix: xserver "make dist" fails due to eventconvert.h
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Gaetan Nadon
QA Contact: Xorg Project Team
Keywords: janitor
Depends on:
Reported: 2009-07-18 18:09 UTC by Gaetan Nadon
Modified: 2009-07-19 03:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

[PATCH] dix: xserver "make dist" fails due to eventconvert.h (821 bytes, patch)
2009-07-18 18:09 UTC, Gaetan Nadon
no flags Details | Splinter Review

Description Gaetan Nadon 2009-07-18 18:09:05 UTC
Created attachment 27825 [details] [review]
[PATCH] dix: xserver "make dist" fails due to eventconvert.h

The dix subdir compiles and links fine, but it prevents the xserver "dist" makefile target to execute. This can be reproduced by doing a full build using ./util/modular/build.sh -D -o xserver/ <prefix> or by running "make dist" from an already built /xserver.

make[1]: *** No rule to make target `eventconvert.h', needed by `distdir'.  Stop.
make: *** [distdir] Error 1

This header file is not in the /dix dir, but in the /include dir.
The makefile aborted and the xserver distribution files were not created.
The fix is to remove this header file from the libdix_la_SOURCES  
in the dix/Makefile.am.

I suppose it once was in /dix and got moved to /include. I provided a patch to fix problem.
Comment 1 Peter Hutterer 2009-07-19 03:14:36 UTC
pushed as 7b9915b11ed9eedd0698b4563328504d686ac4ec. thanks for the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.