When the screen is rotated the calculation of scan lines for MI_LOAD_SCAN_LINES_INCL must apply the f_framebuffer_to_crtc transformation. Otherwise the GPU will hang waiting for a line that is not valid. Testing in all four rotations. The patch assumes that the scan lines returned from the transformation are always valid for the crtc. This patch has only been tested on a single head configuration.
patch?
Created attachment 27155 [details] [review] Patch that fixes XVPutImage in portrait mode Opss, here is the patch
anyone CCed could review/commit?
Looks fine with me. Barry, please send patch to intel-gfx@lists.freedesktop.org for other people to review.
He already did. But unfortunately this doesn't work in dualhead configuration. Even after I've added clipping to scanline calculations it crashes.
Created attachment 27250 [details] [review] Patch with scanline clipping.
All my patches where sent to the intel-gfx list and got no replies except for Lukasz's on dualhead issues. Do you need me to resend?
(In reply to comment #5) > He already did. But unfortunately this doesn't work in dualhead configuration. > Even after I've added clipping to scanline calculations it crashes. Does his patch make things worse for dualhead? Is there a backtrace for the crash, or is it a GPU crash? If it doesn't make things worse, I'm inclined to commit it as-is.
It does NOT make thing worse, just doesn't fix crash for dualhead.
commit b74bf3f9a65af9e72921d4e9028d9d4d023f8bc6 Author: Barry Scott <barry.scott@onelan.co.uk> Date: Mon Jul 13 16:34:20 2009 -0700 Fix XV scan line calculation when rotated.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.