If I have Gabble connected at the same time as another client, and in that other client attempt to subscribe to a contact's presence, Gabble is notified, and the contact pops up on subscribe:remote-pending. But if in the other client I remove them entirely from my roster, they don't disappear from subscribe. The linked branch fixes this bug, but there was code in place specifically to stop this working. Sadly, the commit appears to be a diff|patch to work around darcs. :( I'd appreciate some input from people who worked on the roster in ye olden days.
Apparently the code in place was put there to work around a Google roster bug. I'll have to look into whether that's still applicable.
Removing patch tag until GTalk interop has been investigated.
From what I can reconstruct from looking at discussion from when the workaround was added, in the past, a subscription request being accepted would cause GTalk to send: * A roster update with subscription="to"; * A roster update without subscription="to" and with ask="subscribe"; * A roster update with subscription="to". My branch does not remove the workaround for that. Adding and removing Google Talk contacts on Google Talk accounts seems to work as well with this branch as with master — modulo server bugs like #11883, which I can't see how to work around :( — so re-adding the patch keyword.
(That would be <http://bugs.freedesktop.org/show_bug.cgi?id=11883>.)
<cassidy> wjt: remove-from-rp-subscribe looks good but I'd be more confident if a XMPP guru could check the XMPP logic add a NEWS entry too
I merged a prefix of this branch, but the subscribe:remote-pending patches are still pending further discussion.
Note that this bug actually also occurs with only one client connected: add someone to subscribe, then try to remove them, and it doesn't work.
Merged, will be in 0.7.28.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.