Bug 20841 - comply with telepathy-spec 0.17.22 regarding stream directions
Summary: comply with telepathy-spec 0.17.22 regarding stream directions
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: high normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Keywords: patch
Depends on:
Reported: 2009-03-24 12:11 UTC by Simon McVittie
Modified: 2009-06-02 07:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2009-03-24 12:11:53 UTC
As a result of Bug #20772 the implicit direction and state of new StreamedMedia streams has been clarified in a possibly incompatible way: CMs need to emit extra signals whenever a stream is added with state != Disconnected, direction != Receive or pending-send != Pending_Local_Send.

In Gabble's case, I believe this means that StreamDirectionChanged must be emitted once per stream that is added by the local user, signalling the true direction.
Comment 1 Will Thompson 2009-06-02 07:23:13 UTC
Actually, Gabble already does this:

  tp_svc_channel_type_streamed_media_emit_stream_added (
      chan, id, priv->session->peer, mtype);

  /* Initial stream direction was changed before we had time to hook up
   * signal handler, so we call the handler manually to pick it up. */
  stream_direction_changed_cb (stream, NULL, chan);

I'm going to clarify that comment.
Comment 2 Will Thompson 2009-06-02 07:27:35 UTC
Clarified in 'bug-20841'.
Comment 3 Simon McVittie 2009-06-02 07:33:57 UTC
Patch approved.
Comment 4 Will Thompson 2009-06-02 07:37:42 UTC
Thanks, merged. This will be in 0.7.29.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.