Bug 20442 - Wrong GError emitted on D-Bus when setting avatar fails
Summary: Wrong GError emitted on D-Bus when setting avatar fails
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium trivial
Assignee: Will Thompson
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Keywords: patch
Depends on:
Reported: 2009-03-03 02:36 UTC by Simon McVittie
Modified: 2009-04-28 06:06 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2009-03-03 02:36:35 UTC
When setting the avatar fails, Gabble does not correctly re-map the error from its internal XMPP GError domain to TP_ERRORS. As a result, "org.freedesktop.DBus.GLib.UnmappedError.GabbleXmppError.Code3" is raised.

This can probably be reproduced by setting an excessively large avatar on a Google Talk account.
Comment 1 Simon McVittie 2009-04-14 06:17:43 UTC
wjt/no-avatar-for-you seems to (attempt to?) fix this. Is this a candidate for review? Does it claim to fix this bug? (if so please reference it as fd.o#20422 in the commit messages)
Comment 2 Will Thompson 2009-04-14 06:38:48 UTC
ISTR I wanted to do some more refactoring. I'll pick it back up when I have a minute.
Comment 3 Will Thompson 2009-04-25 04:09:21 UTC
I've updated the branch. I think it's ready for review.

 src/conn-avatars.c                      |   34 +++++++++++++++++++++++-
 tests/twisted/Makefile.am               |    1 +
 tests/twisted/vcard/test-vcard-cache.py |    4 +++
 tests/twisted/vcard/update-rejected.py  |   42 +++++++++++++++++++++++++++++++
 4 files changed, 79 insertions(+), 2 deletions(-)
Comment 4 Guillaume Desmottes 2009-04-28 05:41:56 UTC
Comment 5 Will Thompson 2009-04-28 06:06:47 UTC
commit 147fa5834680583da510f6d77a5e241b840acc4a
Merge: 481acb3 5d0a31b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date:   Tue Apr 28 14:02:06 2009 +0100

    Merge branch 'no-avatar-for-you'
    Fixes fd.o#20422.
    Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.