I like your patch, it is clean and well-structured. Just out of curiosity - wouldn't it make sense to base it on some french layout (using "include") - or the difference is too bit?

Another thing - would you consider adding <languageList> to your variant?

Thanks for your suggestions.

(In reply to comment #1)
> I like your patch, it is clean and well-structured. Just out of curiosity -
> wouldn't it make sense to base it on some french layout (using "include") - or
> the difference is too bit?

Maybe, we have : 
- first row is unchanged,
- second row all keys are changed (AltGr)
- third row 7 keys are changed (AltGr)
- fourth row 2 keys are changed (AltGr)

I don't know if it is possible to redefine only keys from [AltGr] and [AltGr shift] columns (the two first columns are exactly the same as french layout).

If you think it would be more compliant to xkeybvoard-config coding rules to use "include" directive, I think it is better to apply it.

> Another thing - would you consider adding <languageList> to your variant?
> 

I can prepare a new patch with <languageList><iso639Id>oci</iso639Id></languageList> line.

Just to be sure, the iso639 code for Occitan is oci in iso639-3 and oc in iso638-2. Is it better to use iso639-3 or iso639-2 code (the LANG variable is set to oc) ?

Well, I see groups 2-4 are seriously changed, probably there is no advantage in using "include". So, let's leave things as they are.

So far, I am trying to use 639-3.

Created attachment 23483 [details] [review]
Add support of Occitan layout (languageList tag added)

The patch with langageList tag (also, oc has been replaced by oci).
This patch replaces the previous one.

Good! Committed!