if it was bisected to a commit that's not in 1.6, it can't be a blocker
for 1.6.1...

So it looks like Daniel's commit breaks an assumption made in XGetModifierMapping(). Peter or Daniel, do you think this is a bug in the server or Xlib/XCB?

Bug 24046 is probably about the same issue.

Haven't seen this myself with VMware Workstation nor xmodmap, so apparently there's some specific prerequisite for it to trigger - any ideas what that could be?

(In reply to comment #2)
> So it looks like Daniel's commit breaks an assumption made in
> XGetModifierMapping(). Peter or Daniel, do you think this is a bug in the
> server or Xlib/XCB?
> 
> Bug 24046 is probably about the same issue.
> 
> Haven't seen this myself with VMware Workstation nor xmodmap, so apparently
> there's some specific prerequisite for it to trigger - any ideas what that
> could be?

Is this not fixed in later -- less broken -- versions of the server? I can't test myself as I don't have VMWare Workstation, and even if I did, it's kind of hard to see exactly why a binary-only app is crashing ...

(In reply to comment #2)
> So it looks like Daniel's commit breaks an assumption made in
> XGetModifierMapping(). Peter or Daniel, do you think this is a bug in the
> server or Xlib/XCB?

if it's crashing in the client (judging by the trace) but can be bisected to an X server commit it's likely that we've inadvertently broken the protocol. so my guess it is server side (what server version are we talking here anyway?)

would need at least the protocol flow to see what breaks, or some testcase that's reproducible.

> Haven't seen this myself with VMware Workstation nor xmodmap, so apparently
> there's some specific prerequisite for it to trigger - any ideas what that
> could be?

my bet is some custom modifier key setup that triggers some wrong calculation in the server (or wrong return values). how that could look like - I don't know though.

(In reply to comment #4)
> (what server version are we talking here anyway?)

AFAICT the commit in question was first released in 1.7.


> > Haven't seen this myself with VMware Workstation nor xmodmap, so apparently
> > there's some specific prerequisite for it to trigger - any ideas what that
> > could be?
> 
> my bet is some custom modifier key setup that triggers some wrong calculation
> in the server (or wrong return values). how that could look like - I don't know
> though.

Could it be related to a specific XKB configuration? Or xmodmap?


(In reply to comment #3)
> Is this not fixed in later -- less broken -- versions of the server?

I don't know - Dirk, are you still seeing this with xserver 1.7.x releases?

> I can't test myself as I don't have VMWare Workstation, and even if I did,
> it's kind of hard to see exactly why a binary-only app is crashing ...

Sure, that's where bug 24046 comes in.

It looks like VMware worked around the issue. As of 6.5.3 (IIRC) it no longer happened. I am now running VMware Workstation 7.0.1 with X server 1.7.4 and can confirm that the problem is gone.
I looked around and can't seem to find a copy of VMware 6.5.1 anymore, so I can't go back and try to reproduce the original issue.

Don't know how to close the bug - maybe it was a VMware bug that got exposed by the change to X server behavior? Therefore NOTOURBUG. But I'm not sure this is true - it could indeed be a bug in X that VMware is just working around.

Dirk

(In reply to comment #6)
> It looks like VMware worked around the issue. As of 6.5.3 (IIRC) it no longer
> happened.

I can't seem to find any trace of an intentional workaround for this in the VMware code. Of course it's possible that some change between 6.5.1 and 6.5.3 happened to stop triggering this, but maybe you also updated the X server around the same time?


> I looked around and can't seem to find a copy of VMware 6.5.1 anymore, so I
> can't go back and try to reproduce the original issue.

Try

http://downloads.vmware.com/d/details/workstation_6_5_1_for_linux/dHdiZGQqYiV3


> Don't know how to close the bug - maybe it was a VMware bug that got exposed by
> the change to X server behavior?

Seems more likely to be an issue between the X server and Xlib/XCB.

Nobody seems able to reproduce this anymore, assuming it's fixed. If somebody can still reproduce with recent xserver and Xlib/XCB, please reopen.

I am on sabbatical until 9/23. Upon return I will be unconditionally deleting my complete Inbox.

If you wanted to reach me personally then I take it you know my personal email address - please send your message there instead. For anything else, please send another message after 9/23.

/D