Bug 20027 - Adding xfce Desktop Environment with gnome-screensaver support in xdg-screensaver
Summary: Adding xfce Desktop Environment with gnome-screensaver support in xdg-screens...
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Fathi Boudra
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: 23105
  Show dependency treegraph
 
Reported: 2009-02-10 02:29 UTC by Daniel Yek
Modified: 2010-07-09 09:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
A patch to add support for xfce Desktop Environment running gnome-screensaver (1.53 KB, patch)
2009-02-10 02:29 UTC, Daniel Yek
Details | Splinter Review

Description Daniel Yek 2009-02-10 02:29:25 UTC
Created attachment 22741 [details] [review]
A patch to add support for xfce Desktop Environment running gnome-screensaver

Although xdg-screensaver detects xfce DE correctly, but it doesn't take any action on that DE, making it broken.

My findings, so far, is that:
(1) on Linpus Linux Lite (based on Fedora 8, used on Acer Aspire One), xfce is used with gnome-screensaver.
(2) on Mandriva with xfce Desktop Environment, xscreensaver is used.

So, when xfce is the Desktop Environment, there is probably no default ScreenSaver to be "hard coded".

This patch adds support to xdg-screensaver for xfce Desktop Environment running gnome-screensaver.

I also make sure that xscreensaver detection happens first, so that existing xscreensaver support for the remaining of the Desktop Environments (including xfce) is preserved.
Comment 1 Pablo Castellano (pablog) 2010-04-30 04:11:46 UTC
Review of attachment 22741 [details] [review]:

Hello Daniel.

I have not tested your patch but looks good for me.
Could you adapt it in order to be possible to apply the patch to the latest cvs version?
Comment 2 Daniel Yek 2010-04-30 11:25:14 UTC
I doubt it that I could be responsive enough to this request.
Would you or someone else try to merge it?
(Sorry! Too busy with work.)
Comment 3 Rex Dieter 2010-07-09 09:00:41 UTC
I used something simpler, treating anything running gnome-screensaver similar to how xscreensaver is handled.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.