Bug 19902 - Use TpBaseContactList in Haze
Summary: Use TpBaseContactList in Haze
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on: 31997
Blocks: 16480
  Show dependency treegraph
Reported: 2009-02-02 04:41 UTC by Simon McVittie
Modified: 2011-04-27 07:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2009-02-02 04:41:09 UTC
Haze should implement the stored list defined in spec 0.17.12. For backwards compatibility, it should probably keep the existing "known" list too.

+++ This bug was initially created as a clone of Bug #16480 +++
Comment 1 Simon McVittie 2010-11-30 10:33:09 UTC
The first commit, on the 'stored' branch, just adds the 'stored' list (the original scope of this bug).

Subsequent commits require my telepathy-glib branch from Bug #31997 (and an extra commit to bump the dependency), but I think they're ready for a conditional-on-tp-glib review.
Comment 2 Will Thompson 2010-12-01 04:47:09 UTC
+static void
+haze_contact_list_remove_contacts_async (TpBaseContactList *cl,
+    TpHandleSet *contacts,
+    GAsyncReadyCallback callback,
+    gpointer user_data)
+  tp_simple_async_report_success_in_idle ((GObject *) self, callback,
+      user_data, haze_contact_list_request_subscription_async);


Otherwise this looks okay.
Comment 3 Simon McVittie 2010-12-01 06:01:55 UTC
(In reply to comment #2)
> bzzt.

Oops, fixed.
Comment 4 Will Thompson 2010-12-01 06:16:25 UTC
Ship it. I believe this will work as well as the current implementation does.
Comment 5 Simon McVittie 2010-12-01 07:24:57 UTC
Thanks! This is now only blocked by Bug #31997.
Comment 6 Jonny Lamb 2011-04-27 07:47:33 UTC
commit c5d4b95649e5c4263f1d199760de492084f77fec
Merge: a4a52af fb71058
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date:   Thu Dec 2 12:35:23 2010 +0000

    Merge branch 'base-contact-list'

    Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
    Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19902

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.