Bug 19623 - dbus_bus_get_private doesn't have a dbus-glib wrapper
Summary: dbus_bus_get_private doesn't have a dbus-glib wrapper
Status: RESOLVED DUPLICATE of bug 10095
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: low normal
Assignee: Rob Taylor
QA Contact: John (J5) Palmieri
Keywords: patch
: 23722 (view as bug list)
Depends on:
Reported: 2009-01-16 15:41 UTC by Stian Skjelstad
Modified: 2011-03-28 07:05 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

dbus-glib-0.76-private.patch (2.07 KB, patch)
2009-01-16 15:41 UTC, Stian Skjelstad
Details | Splinter Review

Description Stian Skjelstad 2009-01-16 15:41:10 UTC
Created attachment 22042 [details] [review]

dbus_bus_get_private is not exposed in dbus-glib.
Comment 1 Colin Walters 2009-01-27 15:52:35 UTC
* Small typo, should be "returns DBusGConnection".  
* Could use at least one test too.
Comment 2 Stian Skjelstad 2009-01-27 16:01:20 UTC
I now see that the documentation part was a bit too hasty:

+ * Returns a connection to the given bus. The connection is a global variable
+ * shared with other callers of this function.

Should probably have stated that

+ * Returns a connection to the given bus. The connection will be a private
+ * non-shared connection, that the caller should close when not used anymore.

I spent more time in testing the wrapper than finewriting the documentation
Comment 3 Stian Skjelstad 2009-02-03 13:58:46 UTC

*** This bug has been marked as a duplicate of bug 10095 ***
Comment 4 Colin Walters 2009-09-18 10:59:55 UTC
Comment on attachment 22042 [details] [review]

Looks good.
Comment 5 Colin Walters 2009-09-18 11:04:26 UTC
Tweaked the documentation and pushed:

commit 980b46870aa0e44a04ad1191d7af1d0601577501
Author: Stian Skjelstad <stian@nixia.no>
Date:   Fri Sep 18 14:01:00 2009 -0400

    Bug 19623 - Add dbus_g_bus_get_private
    Useful for cases where you have to get a private connection, among
    them to work around threading issues.
    Signed-off-by: Colin Walters <walters@verbum.org>
Comment 6 Simon McVittie 2011-03-28 07:05:15 UTC
*** Bug 23722 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.