Bug 19224 - input.tablet capabilities is hiding behind wrong check
Summary: input.tablet capabilities is hiding behind wrong check
Alias: None
Product: hal
Classification: Unclassified
Component: hald (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
Keywords: patch
Depends on:
Reported: 2008-12-21 16:37 UTC by Peter Hutterer
Modified: 2009-03-02 13:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

0001-Fix-input.tablet-handling-we-want-ABS_X-ABS_Y-and.patch (2.05 KB, patch)
2008-12-21 16:37 UTC, Peter Hutterer
Details | Splinter Review

Description Peter Hutterer 2008-12-21 16:37:01 UTC
Created attachment 21370 [details] [review]

input.tablet capabilities assignment is wrong, we want to assign it based ont ABS_X, ABS_Y and BTN_TOUCH.

The previous check was hiding behind (ABS_X && !ABS_Y) which (as the comment
suggests) is iffy at best.
Move the check for the BTN_TOUCH bitmask up to the rest of the input.mouse
checking and assign input.tablet accordingly.
Comment 1 Danny Kukawka 2009-01-20 01:05:35 UTC
Fixed with another commit AFAICS.
Comment 2 Peter Hutterer 2009-03-02 13:45:29 UTC
btw. for the next time I'd appreciate it if there was a reference to the commit that fixed the issue.

b0a2575f13ce9b18d07a2798e0d4c83cbb3059e5: fix joystick detection (patch by Ari Mustonen)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.