Bug 19062 - intel_miptree_create_for_region steals region from caller
Summary: intel_miptree_create_for_region steals region from caller
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-12-12 15:00 UTC by Pierre Willenbrock
Modified: 2009-08-24 12:31 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Don't steal renderbuffer from caller in intel_miptree_create_for_region (674 bytes, patch)
2008-12-12 15:00 UTC, Pierre Willenbrock 		Details | Splinter Review
View All

Description Pierre Willenbrock 2008-12-12 15:00:24 UTC 
Created attachment 21106 [details] [review]
Don't steal renderbuffer from caller in intel_miptree_create_for_region

This leads to double-frees of some regions, once from the renderbuffer code and once from the miptree itself. 

This seems to be true for gallium-0.2, too.
Comment 1 Eric Anholt 2008-12-14 19:29:25 UTC 
Committed.  Thanks!

commit e72a44215312ae1f3c812ba28e47b4aec3589de9
Author: Pierre Willenbrock <pierre@pirsoft.de>
Date:   Fri Dec 12 21:18:23 2008 +0100

    intel: Don't steal renderbuffer from caller in intel_miptree_create_for_regi
    
    Fixes double-frees of some regions, once from the renderbuffer code and
    once from the miptree itself.
    
    Bug #19062
Comment 2 Adam Jackson 2009-08-24 12:31:16 UTC 
Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.