Bug 18978 - fix distcheck target -- problems with ChangeLog
Summary: fix distcheck target -- problems with ChangeLog
Alias: None
Product: xorg
Classification: Unclassified
Component: * Other (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: janitor, patch
Depends on:
Blocks: 18997
  Show dependency treegraph
Reported: 2008-12-09 03:14 UTC by Peter Breitenlohner
Modified: 2008-12-16 15:33 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

fix distcheck target (1.57 KB, patch)
2008-12-09 03:14 UTC, Peter Breitenlohner
no flags Details | Splinter Review

Description Peter Breitenlohner 2008-12-09 03:14:52 UTC
Created attachment 20952 [details] [review]
fix distcheck target

The ChangeLog file is generated as part of 'make dist' from the git log.

No need to mention ChangeLog under EXTRA_DIST, this is automatic.

ChangeLog should not be mentioned under *CLEANFILES, not even MAINTAINERCLEANFILES, since in a source tree created from a release tarball there is no way to recreate that file.

This, however, creates the problem that the distcheck target fails due to the newly created ChangLog left over by distclean.

This problem is bypassed in various modules by either mentioning ChangeLog under DISTCLEANFILES or even CLEANFILES (problematic, see above).

Other modules effectively disable distcheck by an explicit dummy rule (equally problematic because that hides, e.g., a missing uninstall-hook).

The attached patch attempts to solve these problems by arranging that distcleancheck ignores the ChangeLog left over by distclean. Since distcleancheck_listfiles is documented in automake-1.10 and was already present in automake-1.8 this method should cause no problems.

The nice aspect is, that all this works behind the scene and requires no changes in the various modules (other that removing the workarounds mentioned above).
Comment 1 Alan Coopersmith 2008-12-16 15:33:00 UTC
Patch applied, pushed and released in util-macros 1.2.1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.