Created attachment 20852 [details] [review] fix linking issue and add proper expat check dbus-glib 0.78 doesn't compile due to missing linking to expat library: ./.libs/libdbus-gtool.a(dbus-gloader-expat.o): In function `description_load_from_string': /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:204: undefined reference to `XML_ParserCreate_MM' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:211: undefined reference to `XML_SetUserData' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:212: undefined reference to `XML_SetElementHandler' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:215: undefined reference to `XML_SetCharacterDataHandler' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:218: undefined reference to `XML_Parse' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:261: undefined reference to `XML_ParserFree' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:247: undefined reference to `XML_ParserFree' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:225: undefined reference to `XML_GetErrorCode' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:229: undefined reference to `XML_ErrorString' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:229: undefined reference to `XML_GetCurrentColumnNumber' /home/users/builder/rpm/BUILD/dbus-glib-0.78/dbus/dbus-gloader-expat.c:229: undefined reference to `XML_GetCurrentLineNumber' collect2: ld returned 1 exit status Attached patch fixes it and adds proper expat check / cleans up linking to expat library. Have fun.
ping
The patch from 64ec55f (bug 19325) added an explicit -lexpat to the LDADD. Is that sufficient for this bug?
let's close this one and call direct linking a sufficient method to solve build problems.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.