There was a discussion on the xorg mailing list that a set of CWARNFLAGS should best be provided by xorg-macros as a central point to define them in a uniform way. Further flags for compilers other than gcc can be added there as appropriate. Likewise a replacement for the rule to build ChangeLog (broken for git-1.6.x) should be included. Using suggestions by various people, I'd like to suggest the attached five patches for util-macros: 1. Reorganize the autoconf macro files, avoiding the need to copy some code from xorgversion.m4 to configure.ac 2. Define the XORG_CHANGELOG amcro and use it for xorg-macros 3. Define XORG_CWARNFLAGS macro 4. Fix XORG_PROG_RAWCPP for cygwin (patch from the xorg mailing list) and finally 5. Bump to 1.2.0
Created attachment 20359 [details] [review] patch 1/5 reorganize
Created attachment 20360 [details] [review] patch 2/5 CHANGELOG
Created attachment 20361 [details] [review] patch 3/5 CWARNFLAGS
Created attachment 20362 [details] [review] patch 4/5 cygwin fix for RAWCPP
Created attachment 20363 [details] [review] patch 5/5 bump to 1.2.0
I’d also grab the dolt macro (including the patch added to cairo for compatability with older versions of bash).
Thanks for the patches. I was only unsure about adding the version bump patch or someone may bump it again prior to a new util-macros release :-) James, you mean http://cgit.freedesktop.org/cairo/commit/?id=1d8ad69abb88f6e0283b6ce2aadc5d801b8e3722 ? I think it should be applied to xserver/acinclude.m4
Marking as closed as there is now a util-macros 1.2.0 with the patches applied.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.