Bug 18106 - [patch] rename the current ARM code to ARM SIMD
Summary: [patch] rename the current ARM code to ARM SIMD
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: 0.1.3
Hardware: ARM All
: medium normal
Assignee: Søren Sandmann Pedersen
QA Contact: Søren Sandmann Pedersen
Keywords: patch
Depends on:
Blocks: 13445
  Show dependency treegraph
Reported: 2008-10-17 07:42 UTC by Adrian Bunk
Modified: 2008-10-31 14:27 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

rename the current ARM code to ARM SIMD (31.24 KB, patch)
2008-10-17 07:42 UTC, Adrian Bunk
Details | Splinter Review

Description Adrian Bunk 2008-10-17 07:42:35 UTC
Created attachment 19720 [details] [review]
rename the current ARM code to ARM SIMD

This code is only for CPUs supporting the SIMD instructions, not for all ARM CPUs.

I stumbled above the recent commit with the ARM SIMD code while preparing a patch that models the patch from #13445 after the MMX and SSE2 cases:

The ARM SIMD option currently uses --disable-arm, although this code is only for CPUs >= ARMv6. That's as if one would call the option to disable the SSE2 code --disable-x86.

This patch therefore renames the configure option and the function and file names to arm-simd/arm_simd.
Comment 1 Søren Sandmann Pedersen 2008-10-31 11:52:04 UTC
Looks fine to me.
Comment 2 Søren Sandmann Pedersen 2008-10-31 12:04:14 UTC
In master.
Comment 3 Adrian Bunk 2008-10-31 14:27:31 UTC
(In reply to comment #2)
> In master.

Thanks.  :-)

One thing I noted when looking at the commit in master is that the files are removed instead of moved. Did you forget a "git add" before committing?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.