Bug 17798 - add support for 'o', 'g' and 'as' in dictionaries
Summary: add support for 'o', 'g' and 'as' in dictionaries
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Robert McQueen
QA Contact: John (J5) Palmieri
Keywords: patch
Depends on: 17797
Blocks: 17329
  Show dependency treegraph
Reported: 2008-09-26 09:03 UTC by Robert McQueen
Modified: 2008-11-28 19:24 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

add support for 'o', 'g' and 'as' in dictionaries (7.65 KB, patch)
2008-09-26 09:11 UTC, Robert McQueen
Details | Splinter Review

Description Robert McQueen 2008-09-26 09:03:51 UTC
This teaches the parameterised hash table about how to hash, compare and
free object paths and signatures, allowing them to be used as hash keys
and values, and also how to free strvs, so they can be used as values.
Adds some simple test methods which echo a{gas} and a{oas} dictionaries
back immediately and compare the results.
Comment 1 Robert McQueen 2008-09-26 09:11:01 UTC
Created attachment 19245 [details] [review]
add support for 'o', 'g' and 'as' in dictionaries
Comment 2 Colin Walters 2008-09-30 08:48:33 UTC
One thing that occurs to me is if it's worth opening a GObject bug for adding support for hash functions to boxed registration.  Then we could remove this special casing.  Maybe it's not worth it though.

Can you also add a test for the STRV case?  

Otherwise looks like it should work, please commit.
Comment 3 Robert McQueen 2008-11-28 19:24:07 UTC
There is a test for the STRV case - it's not a valid dictionary key and both the a{gas} and a{oas} tests test it as a value. Merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.