Bug 17795 - depend on Glib 2.10 for hash unref consistency
Summary: depend on Glib 2.10 for hash unref consistency
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Robert McQueen
QA Contact: John (J5) Palmieri
Keywords: patch
Depends on:
Blocks: 17329
  Show dependency treegraph
Reported: 2008-09-26 09:01 UTC by Robert McQueen
Modified: 2008-11-28 12:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

depend on Glib 2.10 for hash unref consistency (2.04 KB, patch)
2008-09-26 09:10 UTC, Robert McQueen
Details | Splinter Review

Description Robert McQueen 2008-09-26 09:01:45 UTC
Commit a8bf32 (for bug #11396) introduced a compile-time version check
for Glib 2.10 which changed whether hash_simple_free called
g_hash_table_unref or g_hash_table_destroy. This is at best useless for
people who actually wanted to rely on _unref being used instead of
_destroy, because dbus-glib can legitimately be built against older
versions of Glib than that in use by the application itself, and at
worst harmful as applications relying on the _unref semantics would have
their assumptions violated on platforms where this was the case. Given
in /most/ cases now, Glib 2.10 is readily available, and we were in this
kinda vague state where people could've used _unref and gotten away with
it, I'm going to say thats what our ABI is now, and stick to it. People
can depend on the next version of dbus-glib if they rely on _unref.
Comment 1 Robert McQueen 2008-09-26 09:10:09 UTC
Created attachment 19243 [details] [review]
depend on Glib 2.10 for hash unref consistency
Comment 2 Colin Walters 2008-09-26 09:13:28 UTC
Looks good, please apply.
Comment 3 Robert McQueen 2008-11-28 12:32:56 UTC

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.