Bug 17794 - make run-test.sh fail when die is called
Summary: make run-test.sh fail when die is called
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Robert McQueen
QA Contact: John (J5) Palmieri
Keywords: patch
Depends on:
Reported: 2008-09-26 09:00 UTC by Robert McQueen
Modified: 2008-11-28 12:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

make run-test.sh fail when die is called (800 bytes, patch)
2008-09-26 09:09 UTC, Robert McQueen
Details | Splinter Review

Description Robert McQueen 2008-09-26 09:00:44 UTC
Missing die() function meant this wasn't returning non-zero even when
tests were failing. Oops.
Comment 1 Robert McQueen 2008-09-26 09:09:08 UTC
Created attachment 19242 [details] [review]
make run-test.sh fail when die is called
Comment 2 Colin Walters 2008-09-26 09:21:15 UTC
Can we use set -e?
Comment 3 Robert McQueen 2008-11-28 12:32:45 UTC
This way prints more informatively what failed. Merging anyway, feel free to reopen with an alternative patch if you feel strongly. :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.