Bug 17793 - delete bonged EchoVariant test method
Summary: delete bonged EchoVariant test method
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Rob Taylor
QA Contact: John (J5) Palmieri
Keywords: patch
Depends on:
Reported: 2008-09-26 08:59 UTC by Robert McQueen
Modified: 2008-11-28 12:30 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

delete bonged EchoVariant test case (2.23 KB, patch)
2008-09-26 09:08 UTC, Robert McQueen
Details | Splinter Review

Description Robert McQueen 2008-09-26 08:59:37 UTC
No way is this correct, it writes into the returned variant GValue
without actually allocating it. I guess that's why it wasn't actually
being called. :)
Comment 1 Robert McQueen 2008-09-26 09:08:41 UTC
Created attachment 19241 [details] [review]
delete bonged EchoVariant test case
Comment 2 Colin Walters 2008-09-30 08:40:09 UTC
I think the way returned variants are handled is special in the sense that dbus-glib will allocate it for you.  Did you try calling it and it crashed?
Comment 3 Robert McQueen 2008-11-28 12:30:22 UTC
Ok, so it seems, upsettingly, that this is in fact a valid API use. Invalidating this bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.