Created attachment 19045 [details] [review]
In HAL 0.5.11 and 0.5.10 (but not 0.5.9), mounting a device using the NTFS filesystem with KDE fails with an error "TODO: have to rethink extra options". It mounts however if I configure KDE not to mount the device in 'user' mode.
It seems the error is because HAL doesn't consider NTFS a filesystem that doesn't really store uids. I'm attaching a patch that solves the problem described by adding a check for ntfs as well.
I also added 'ntfs-3g' to the list because many distributions, when integrating the ntfs-3g driver with HAL, change the 'ntfs' fstype to 'ntfs-3g'. Example:
I confirm the bug is present and the patch that fixes it works.
Created attachment 19913 [details] [review]
fix by removing uid checks
This patch removes the hardcoded policy to only allow the "uid" option on some filesystems.
I say these checks make no sense, and it is very bad to hardcode such policies.
All required restrictions are already in the fdi as filesystem-specific available mount options, AFAIK.
Fixed in git.