Bug 1573 - gb18030 support
Summary: gb18030 support
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: git
Hardware: Other Linux (All)
: high normal
Assignee: Egbert Eich
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2004-10-09 10:49 UTC by Stefan Dirsch
Modified: 2008-11-22 10:59 UTC (History)
7 users (show)

See Also:
i915 platform:
i915 features:

p_XFree86-4.2.0-i18n-xlib-20020322.diff (840.67 KB, patch)
2004-10-09 10:51 UTC, Stefan Dirsch
no flags Details | Splinter Review
p_XFree86-4.3.0-i18n-font_encodings-20030609.diff (54.27 KB, patch)
2004-10-09 10:52 UTC, Stefan Dirsch
no flags Details | Splinter Review
p_XFree86-4.3.0-i18n-nls-20030609.diff (21.38 KB, patch)
2004-10-09 10:53 UTC, Stefan Dirsch
no flags Details | Splinter Review

Description Stefan Dirsch 2004-10-09 10:49:36 UTC
I'll attach 3 patches required for gb18030 support. SuSE got them by SUN 
(AFAIK originally made by James Su) and James Su made fixes later for them. 
Needs to be discussed.
Comment 1 Stefan Dirsch 2004-10-09 10:51:16 UTC
Created attachment 1051 [details] [review]
Comment 2 Stefan Dirsch 2004-10-09 10:52:18 UTC
Created attachment 1052 [details] [review]
Comment 3 Stefan Dirsch 2004-10-09 10:53:18 UTC
Created attachment 1053 [details] [review]
Comment 4 Stefan Dirsch 2004-10-11 02:32:35 UTC
Needs to be discussed outside of Bugzilla first.  
Comment 5 Stefan Dirsch 2004-10-12 07:51:18 UTC
reopen for discussion. 
Comment 6 Stefan Dirsch 2004-10-12 07:55:28 UTC
Needs to be discussed with Mike and James. Mike, would you please add James 
Comment 7 Stefan Dirsch 2004-10-12 07:58:27 UTC
The big converting tables in p_XFree86-4.2.0-i18n-xlib-20020322.diff are 
considered problematic and might better be replaced with the use of glibc. 
Comment 8 Egbert Eich 2004-10-17 01:52:18 UTC
I would like to commit Attachment #1052 [details] and #1053. However I'm unable to test
this at all. 
James, could you please add a commtent what those patches do and if you think
they are OK?
I also would need to know the original author. James, did you do them?
Comment 9 James Su 2004-10-18 07:08:37 UTC
  Yes, these patches were written by me, in order to let XFree86 support
GB18030, GBK and BIG5-HKSCS locales correctly. These patches have been used in
many distributions for years, eg. TurboLinux, RedHat, SuSE, and some local
distributions in China.
  I had submitted them to XFree86 group, but had not been accepted yet.

  Patch p_XFree86-4.2.0-i18n-xlib-20020322.diff is necessary to support GB18030
locale, so please consider to commit it.

James Su
Comment 10 Egbert Eich 2004-10-18 10:32:22 UTC
> I had submitted them to XFree86 group, but had not been accepted yet.
Yes, I know. It was partly my fault. The problem was that there were several
different versions of these patches floating around which differed slightly.

Attachment 1052 [details] and 1053 are committed to X.Org now.

I need to think how to handle the big conversion tables. Maybe I make them optional.
Comment 11 Erik Andren 2006-03-22 04:20:15 UTC
Whats the status of this bug today? Should it be closed?
Comment 12 Stefan Dirsch 2006-03-22 04:27:05 UTC
No, attachment #51 [details] [review] is still not committed.
Comment 13 Daniel Stone 2007-02-27 01:24:18 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 14 Stefan Dirsch 2007-11-04 08:20:28 UTC
Egbert? SUSE is now using the remaining patch since about 6 years ...
Comment 15 Stefan Dirsch 2008-11-22 10:59:04 UTC
Patch committed now to libX11 git head.

commit 67e34d7a82ccd31f1208c0c43a6d58c3c05bf51a
Author: Stefan Dirsch <sndirsch@suse.de>
Date:   Sat Nov 22 19:40:54 2008 +0100

    Added remaining xlib patch required for gb18030 support (#1573).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.