Bug 15706 - [915GM EXA] GIF image crashes (BadAlloc) Gecko-based browsers when running 2.3.0 driver
Summary: [915GM EXA] GIF image crashes (BadAlloc) Gecko-based browsers when running 2....
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Wang Zhenyu
QA Contact: Xorg Project Team
URL: http://cdn.shacknews.com/public/shack...
Whiteboard:
Keywords: NEEDINFO
: 17022 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-24 22:59 UTC by kmike
Modified: 2008-08-07 00:27 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Xorg log file for 2.3.0 (56.40 KB, text/plain)
2008-04-24 22:59 UTC, kmike
no flags Details
10000x4 GIF file that causes BadAlloc (681 bytes, image/gif)
2008-04-24 23:03 UTC, kmike
no flags Details

Description kmike 2008-04-24 22:59:43 UTC
Created attachment 16172 [details]
Xorg log file for 2.3.0

When running Intel X.org driver 2.3.0 release, the 10000x4 GIF image from the URL crashes Firefox 2.0.0.14 and SeaMonkey/2.0a1pre with BadAlloc error.

The same image doesn't crash when running xorg-x11-drv-i810-2.1.1-7.fc8 driver.

System details:
Toshiba Satellite M55.S325 running Fedora Core 8

00:00.0 Host bridge: Intel Corporation Mobile 915GM/PM/GMS/910GML Express Processor to DRAM Controller (rev 03)
00:02.0 VGA compatible controller: Intel Corporation Mobile 915GM/GMS/910GML Express Graphics Controller (rev 03)
00:02.1 Display controller: Intel Corporation Mobile 915GM/GMS/910GML Express Graphics Controller (rev 03)

Linux toshiba 2.6.24.3-13_1.cubbi_tuxonice.fc8 #1 SMP Sat Mar 1 19:33:14 CET 2008 i686 i686 i386 GNU/Linux

xorg-x11-drv-intel-2.3.0-1.fc8.i386 (built using xorg-x11-drv-i810.spec as a template)
xorg-x11-server-Xorg-1.3.0.0-44.fc8
libdrm-2.3.0-7.fc8
mesa-libGL-7.0.2-3.fc8
Comment 1 kmike 2008-04-24 23:03:55 UTC
Created attachment 16173 [details]
10000x4 GIF file that causes BadAlloc
Comment 2 kmike 2008-04-24 23:16:27 UTC
BadAlloc errors when crashing Seamonkey:

Gdk-ERROR **: The program 'seamonkey-bin' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAlloc (insufficient resources for operation)'.
  (Details: serial 9199 error_code 11 request_code 53 minor_code 0)

Gdk-ERROR **: The program 'seamonkey-bin' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAlloc (insufficient resources for operation)'.
  (Details: serial 9832 error_code 11 request_code 53 minor_code 0)

Error when crashing Firefox:

Gdk-ERROR **: The program 'gecko' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAlloc (insufficient resources for operation)'.
  (Details: serial 9718 error_code 11 request_code 53 minor_code 0)
Comment 3 Wang Zhenyu 2008-04-25 02:03:04 UTC
gordon, you might try to test on 915GM. I can't see firefox crash on my 915G. Mine is debian's iceweasel 2.0.0.13.
Comment 4 Julien Cristau 2008-04-25 02:13:38 UTC
> --- Comment #3 from Wang Zhenyu <zhenyu.z.wang@intel.com>  2008-04-25 02:03:04 PST ---
> gordon, you might try to test on 915GM. I can't see firefox crash on my 915G.
> Mine is debian's iceweasel 2.0.0.13.
> 
I think this might be a bug in exa fixed in the server since 1.3, there
was a commit by Eric to fix an overly restrictive check in
exaCreatePixmap a while ago.

Cheers,
Julien
Comment 5 kmike 2008-04-25 03:25:58 UTC
(In reply to comment #4)
> I think this might be a bug in exa fixed in the server since 1.3, there
> was a commit by Eric to fix an overly restrictive check in
> exaCreatePixmap a while ago.
> 
> Cheers,
> Julien

Looks like that was it! Putting

Option      "AccelMethod" "XAA"

into xorg.conf fixes the crash.

I'm not sure of the proper resolution for this bug. Should it be FIXED or WORKSFORME?
Comment 6 Gordon Jin 2008-04-25 23:10:06 UTC
(In reply to comment #5)
> I'm not sure of the proper resolution for this bug. Should it be FIXED or
> WORKSFORME?

So it's EXA bug. Let's keep this open until confirming the fix has been committed.

kmike, can you use the latest xserver to verify?

Eric, can you provide the commit mentioned in comment#4? 
Comment 7 Julien Cristau 2008-04-27 13:39:29 UTC
> --- Comment #6 from Gordon Jin <gordon.jin@intel.com>  2008-04-25 23:10:06 PST ---
> Eric, can you provide the commit mentioned in comment#4? 
> 
FWIW, I was talking about bc2d516f16d94c805b4dfa8e5b9eef40ff0cbe98.
No idea whether this is in F8.

Cheers,
Julien
Comment 8 Gordon Jin 2008-04-28 00:05:21 UTC
Thanks Julien.

kmike, can you verify if below patch fixes?

diff-tree bc2d516f16d94c805b4dfa8e5b9eef40ff0cbe98 (from feb1b3e45513bd6eaa2e6a5ee536183f20d9cb68)
Author: Eric Anholt <eric@anholt.net>
Date:   Fri Aug 17 12:14:16 2007 -0700

    Fix overly-restrictive integer overflow check in EXA pixmap creation.
    
    The result was that at 32bpp, pixmaps of width 8192 or greater couldn't be
    created, due to treating a pitch value as a width.

diff --git a/exa/exa.c b/exa/exa.c
index aa42b92..b2faf2f 100644
--- a/exa/exa.c
+++ b/exa/exa.c
@@ -253,7 +253,7 @@ exaCreatePixmap(ScreenPtr pScreen, int w
 				     pExaScr->info->pixmapPitchAlign);
     pExaPixmap->fb_size = pExaPixmap->fb_pitch * h;
 
-    if (pExaPixmap->fb_pitch > 32767) {
+    if (pExaPixmap->fb_pitch > 131071) {
 	fbDestroyPixmap(pPixmap);
 	return NULL;
     }
Comment 9 kmike 2008-04-29 04:54:43 UTC
Unfortunately I can't recompile xserver as of this moment. Will 1.5.0-pre from Fedora Rawhide be sufficient?
http://rpmfind.net//linux/RPM/fedora/devel/i386/xorg-x11-server-Xorg-1.4.99.901-26.20080415.fc9.i386.html
Comment 10 Gordon Jin 2008-04-30 02:04:39 UTC
(In reply to comment #9)
> Unfortunately I can't recompile xserver as of this moment. Will 1.5.0-pre from
> Fedora Rawhide be sufficient?
> http://rpmfind.net//linux/RPM/fedora/devel/i386/xorg-x11-server-Xorg-1.4.99.901-26.20080415.fc9.i386.html
> 

Maybe you can give it a try. But I'm not optimistic.

Comment 11 Gordon Jin 2008-06-04 00:07:31 UTC
I'm closing this. Please reopen if you find new xserver including the patch doesn't help.
Comment 12 Michel Dänzer 2008-08-07 00:27:08 UTC
*** Bug 17022 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.