Bug 15590 - Ensure clock gating is fully enabled on 965GM
Summary: Ensure clock gating is fully enabled on 965GM
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Jesse Barnes
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2008-04-18 13:10 UTC by Matthew Garrett
Modified: 2008-05-27 02:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Enable all clock gating except known-broken options (1004 bytes, patch)
2008-04-18 13:10 UTC, Matthew Garrett
no flags Details | Splinter Review
Updated clock gating patch (2.77 KB, patch)
2008-05-20 16:50 UTC, Jesse Barnes
no flags Details | Splinter Review

Description Matthew Garrett 2008-04-18 13:10:49 UTC
Created attachment 16024 [details] [review]
Enable all clock gating except known-broken options

The 965GM path (at least) doesn't clear all the bits that the BIOS has set for disabling clock gating. This patch seems to work for me.
Comment 1 Jesse Barnes 2008-05-20 16:50:08 UTC
Created attachment 16656 [details] [review]
Updated clock gating patch

I found an old patch that was similar to yours.  I updated it with some new stuff, care to try it out?
Comment 2 Jesse Barnes 2008-05-20 16:51:23 UTC
Gordon, can we get some test coverage on this one?  We need to make sure 965G, 965GM and future platforms work ok with these clock gate disable settings.  It would probably be best to run it through all the stress tests you have, with idle periods in between.

Comment 3 Gordon Jin 2008-05-24 00:27:35 UTC
Jesse, just a quick report. I've run it on 2 machines and haven't found new issues. I hope to do more coverage before next Tuesday.
Comment 4 Jesse Barnes 2008-05-24 07:49:13 UTC
Thanks Gordon, these options may not save a lot of power, but they might prevent rendering bugs or hangs.  Let me know when you're comfortable with the changes, stability-wise, and I'll go ahead and push.

Comment 5 Jesse Barnes 2008-05-26 09:36:10 UTC
Fixed in 89bb53cc7a853d88fc34a0ca65ae2b6227a8dd24
Comment 6 Gordon Jin 2008-05-27 02:31:39 UTC
Jesse, the patch runs well on my 965, GM965, and the next mobile platform.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.