Bug 15048 - xorg/driver/xf86-video-chips - Compile warning fixes
Summary: xorg/driver/xf86-video-chips - Compile warning fixes
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/chips (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Egbert Eich
QA Contact: Xorg Project Team
Keywords: janitor, patch
Depends on:
Reported: 2008-03-15 19:57 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-23 11:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-Compile-warning-fixes.patch (11.02 KB, patch)
2008-03-15 19:57 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-15 19:57:36 UTC
Created attachment 15168 [details] [review]

Ansify functions in AsmMacros.h. These are used only in this driver
so there should not exist any problems, but the functions receive char/short
  Declare as static some functions from the utility programs to avoid
warning about missing prototypes.
  Include <unistd.h> for usleep prototype.
  Don't declare some unused variables, or move them to the appropriate ifdef.
Comment 1 Paulo César Pereira de Andrade 2008-07-23 11:21:58 UTC
  This patch attempted to correct some somewhat funny
code like:

static inline unsigned int foo(a, b)
  short a;
  char b;
   bar((short)a, (char)b);

declared in a header file.

  Maybe the proper patch would be to actually promote
types when doing the ansification, so that it should
be binary compatible, but should work either way.

  Anyway, it is not really a bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.