Bug 15036 - xorg/driver/xf86-video-sunffb - Compile warning fixes
Summary: xorg/driver/xf86-video-sunffb - Compile warning fixes
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: janitor, patch
Depends on:
Reported: 2008-03-15 17:09 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-23 11:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-Compile-warning-fixes.patch (3.91 KB, patch)
2008-03-15 17:09 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-15 17:09:44 UTC
Created attachment 15156 [details] [review]

Add prototypes to ffh.h.
  If 0 static unused functions.
  Protect definition of FFBSync() around ifdef, as there are also macro
versions (one for debug and one that is a noop), and the function definition
does nothing.

  Just because it compiles in x86 :-)
Comment 1 Paulo César Pereira de Andrade 2008-07-23 11:00:37 UTC
  It compiled correctly when adding prototypes to
a header file, and since there are no type promotions,
this is not really a bug.
  The protection of a function also defined as a
macro could be useful, but it is probably just a
debugging feature that was left in the sources.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.